Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webgl2 IDL spec and generated code #18

Merged
merged 22 commits into from
May 3, 2022
Merged

Add webgl2 IDL spec and generated code #18

merged 22 commits into from
May 3, 2022

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented May 2, 2022

I've added WebGL 2 example code to DOMKitDemo ported from https://webgl2fundamentals.org/webgl/lessons/webgl-fundamentals.html, which is under MIT/BSD3-like license (added inline to the file), looks like this in action after you press the button. Just a pink triangle, but it finally works!

Screenshot 2022-05-03 at 16 33 44

@MaxDesiatov MaxDesiatov added the enhancement New feature or request label May 2, 2022
Base automatically changed from maxd/webgl1 to main May 3, 2022 15:17
# Conflicts:
#	Sources/DOMKit/Generated.swift
#	parse-idl/parse-all.js
@MaxDesiatov MaxDesiatov requested a review from a team May 3, 2022 15:35
@MaxDesiatov MaxDesiatov marked this pull request as ready for review May 3, 2022 15:35
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting to see WebAPIKit code actually being run is awesome! And after my brush with OpenGL in C++ last fall I think the argument labels alone are a MASSIVE improvement haha. Thanks for pushing this through!

Comment on lines 10 to 11
//extension WebGL2RenderingContext: Any_RenderingContext {}
//extension WebGLRenderingContext: Any_RenderingContext {}
// extension WebGL2RenderingContext: Any_RenderingContext {}
// extension WebGLRenderingContext: Any_RenderingContext {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be uncommented, right?

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented May 3, 2022

Thanks! I'm thinking of integrating Euclid with WebGL 2 via WebAPIKit. Thankfully, Euclid already compiles and passes all tests almost without issues. It would take time to make something comparable to three.js, but could be a start.

@MaxDesiatov MaxDesiatov merged commit aa4d781 into main May 3, 2022
@MaxDesiatov MaxDesiatov deleted the maxd/webgl2 branch May 3, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants