Skip to content

Use upstream swift-doc with prebuilt Docker image #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

MaxDesiatov
Copy link
Contributor

Thanks to SwiftDocOrg/swift-doc#111 we probably no longer need to use a forked version of swift-doc.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Thanks to SwiftDocOrg/swift-doc#111 we probably no longer need to use a forked version of `swift-doc`.
@MaxDesiatov MaxDesiatov added the documentation Improvements or additions to documentation label Sep 25, 2020
@MaxDesiatov MaxDesiatov marked this pull request as ready for review September 25, 2020 10:46
@github-actions
Copy link

github-actions bot commented Sep 25, 2020

Time Change: +554ms (3%)

Total Time: 15,295ms

Test name Duration Change
Serialization/Write JavaScript string directly 201ms +11ms (5%) 🔍
Serialization/Swift String to JavaScript 5,831.5ms +343ms (5%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 187.5ms -1.5ms (0%)
Serialization/Swift Int to JavaScript 5,551.5ms +77.5ms (1%)
Object heap/Increment and decrement RC 3,523.5ms +124ms (3%)

performance-action

@MaxDesiatov MaxDesiatov requested a review from a team September 25, 2020 10:46
@MaxDesiatov MaxDesiatov merged commit ee6699b into master Sep 25, 2020
@MaxDesiatov MaxDesiatov deleted the upstream-swift-doc branch September 25, 2020 13:08
MaxDesiatov added a commit that referenced this pull request Sep 25, 2020
Thanks to SwiftDocOrg/swift-doc#111 we probably no longer need to use a forked version of `swift-doc`.
@MaxDesiatov
Copy link
Contributor Author

The base branch was master, which was incorrect, I've cherry-picked it to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants