Skip to content

Add Prettier, reformat JS code #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Add Prettier, reformat JS code #69

merged 7 commits into from
Sep 24, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Sep 23, 2020

See #68 (comment). This introduces a bunch of changes so I wanted to pull it into a separate PR so we can bikeshed on options if necessary.

@MaxDesiatov
Copy link
Contributor

Could you also add .pre-commit-config.yml with a prettier snippet as described here, and we could add SwiftFormat and SwiftLint to it in future PRs?

@j-f1
Copy link
Member Author

j-f1 commented Sep 23, 2020

I’m trying but it’s not working ¯\_(ツ)_/¯

Screenshot_2020-09-23 19 43 30

it’s been like that for several minutes.

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'll try to add pre-commit in a separate PR

@j-f1

This comment has been minimized.

@j-f1 j-f1 merged commit 76bbe70 into master Sep 24, 2020
@j-f1 j-f1 deleted the prettier branch September 24, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants