Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JavaScriptTypedArrayKind #58

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Remove JavaScriptTypedArrayKind #58

merged 3 commits into from
Sep 16, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Sep 16, 2020

Fixes #52.

@j-f1
Copy link
Member Author

j-f1 commented Sep 16, 2020

Reading through #57 reminded me that I did not bump the library version in #31. Is this an issue? Also, what’s the standard for how much to increment the version?

@kateinoigakukun
Copy link
Member

I did not bump the library version in #31. Is this an issue?

This is not a big issue because I bumped the version before releasing 0.6.0.

Also, what’s the standard for how much to increment the version?

At least it's ok if it's greater than the old value.

@kateinoigakukun kateinoigakukun merged commit 6652885 into master Sep 16, 2020
@kateinoigakukun kateinoigakukun deleted the typed-array-update branch September 16, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypedArray improvement?
2 participants
@j-f1 @kateinoigakukun