Skip to content

Use swiftwasm/setup-swiftwasm instead of swiftenv on CI #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2022

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@kateinoigakukun kateinoigakukun force-pushed the katei/use-setup-swiftwasm branch from 0064e5b to d877d70 Compare October 8, 2022 04:23
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

Time Change: +293ms (1%)

Total Time: 18,326ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 24ms -1ms (5%)
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 22ms +1ms
Serialization/JavaScript function call from Swift 194ms +5ms (2%)
Serialization/Swift Int to JavaScript with assignment 440ms -7ms (1%)
Serialization/Swift Int to JavaScript with call 1,385ms +9ms (0%)
Serialization/JavaScript Number to Swift Int 464ms -4ms (0%)
Serialization/Swift String to JavaScript with assignment 505ms -5ms (0%)
Serialization/Swift String to JavaScript with call 1,487ms +19ms (1%)
Serialization/JavaScript String to Swift String 5,853ms +132ms (2%)
Object heap/Increment and decrement RC 7,936ms +151ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 3ms

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Oct 8, 2022

The old main branch expects to have swiftenv, so perf job is failing now. But it will be back to green after merging this.

@kateinoigakukun kateinoigakukun requested a review from a team October 8, 2022 04:44
@@ -2,7 +2,6 @@ MAKEFILE_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

.PHONY: bootstrap
bootstrap:
./scripts/install-toolchain.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this script file be deleted too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still useful for installing the default toolchain without carton, and I still use it.

@kateinoigakukun kateinoigakukun merged commit 60ca6b5 into main Oct 9, 2022
@kateinoigakukun kateinoigakukun deleted the katei/use-setup-swiftwasm branch October 9, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants