Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup & improvements to perf-tester #186

Merged
merged 8 commits into from
Apr 10, 2022
Merged

Cleanup & improvements to perf-tester #186

merged 8 commits into from
Apr 10, 2022

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Apr 9, 2022

  • clean up the code to remove unnecessary configuration options and other cruft from the original action
  • quadruple the number of total benchmark runs, hopefully reducing the amount of noise regularly seen in benchmark runs
  • remove false precision in the reported numbers
  • tweak the automatic comment slightly

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

Time Change: +942ms (10%) ⚠️

Total Time: 8,784ms

Test name Duration Change
Serialization/Swift Int to JavaScript 2,864ms +516ms (18%) ⚠️
Serialization/Swift String to JavaScript 2,672.75ms +291.5ms (10%) ⚠️
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 173.5ms +2.25ms (1%)
Serialization/Write JavaScript string directly 176ms -5.5ms (3%)
Object heap/Increment and decrement RC 2,897.75ms +137.75ms (4%)

@j-f1 j-f1 changed the title Remove outdated attribution from perf-tester comments Cleanup & improvements to perf-tester Apr 9, 2022
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

Time Change: -164ms (1%)

Total Time: 15,566ms

Test name Duration Change
Serialization/Write JavaScript string directly 378ms +22ms (5%) 🔍
View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 334ms -2ms (0%)
Serialization/Swift Int to JavaScript 4,987ms -68ms (1%)
Serialization/Swift String to JavaScript 5,052ms -122ms (2%)
Object heap/Increment and decrement RC 4,816ms +6ms (0%)

@j-f1 j-f1 marked this pull request as ready for review April 10, 2022 13:56
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@j-f1 j-f1 merged commit a5a980d into main Apr 10, 2022
@j-f1 j-f1 deleted the jed/update-perf-tester branch April 10, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants