Install Toolchain #1780
Merged
Install Toolchain #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
roulpriya
force-pushed
the
installing-swiftly-toolchain
branch
3 times, most recently
from
845d30a to
3b13b09
Compare
roulpriya
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
requested changes
Aug 15, 2025
Member
matthewbastien
left a comment
matthewbastien
left a comment
There was a problem hiding this comment.
Looking really good so far! Here are some things I noticed while testing this out locally:
- The toolchain selection dialog is getting really big with this change. I think it makes more sense to make the Swiftly install a separate VS Code command and add it as an action to the toolchain selection dialog. Toolchain selection is more about switching between already installed toolchains anyway.
- Toolchains should be ordered most recent first rather than earliest. E.g. 6.1.1 should be at the top.
award999
reviewed
Aug 18, 2025
award999
reviewed
Aug 18, 2025
roulpriya
force-pushed
the
installing-swiftly-toolchain
branch
from
5cd66b3 to
76f3df7
Compare
award999
reviewed
Aug 21, 2025
Contributor
award999
left a comment
award999
left a comment
There was a problem hiding this comment.
Looking good, some smaller things
roulpriya
force-pushed
the
installing-swiftly-toolchain
branch
3 times, most recently
from
80b67fe to
a1515c6
Compare
award999
reviewed
Aug 26, 2025
roulpriya
force-pushed
the
installing-swiftly-toolchain
branch
from
a1515c6 to
9ef0ecf
Compare
award999
approved these changes
Aug 26, 2025
matthewbastien
approved these changes
Aug 27, 2025
| return; | ||
| } | ||
|
|
||
| const availableToolchains = await Swiftly.listAvailable(ctx.logger); |
Member
There was a problem hiding this comment.
This can be addressed in a future PR, but on my machine swiftly list-available does not show any snapshots by default. I have to be more specific and explicitly ask for 6.2-snapshot: swiftly list-available 6.2-snapshot.
This command always says "you have installed all available snapshots" even though I could update to a newer 6.2-snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Issue #1778
Description
Issue: 1778
Tasks