Fail tests if they crash #1505
Merged
Fail tests if they crash #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
plemarquand
force-pushed
the
fail-test-on-crash
branch
3 times, most recently
from
eaab355 to
56d3c02
Compare
matthewbastien
approved these changes
Apr 16, 2025
If a test crashes during a test run the extension never marks the test as failed, since it doesn't see the output that marks the test as completed. If we finish a test run and we still have a test in the 'pending' state where no pass/fail/skip has been seen, mark the test as failed with a message stating the test never finished. Issue: swiftlang#1504
plemarquand
force-pushed
the
fail-test-on-crash
branch
from
56d3c02 to
2395570
Compare
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Apr 22, 2025
Sometimes when running tests that print user output during their execution this output can be printed on the same line as XCTest results output, either before or after the results string. Previously this showed as a test that never finished (pending) in then test explorer, but with the introduction of swiftlang#1505 tests that start but don't find any completion output are assumed to be crashed and marked as failed. This extra user output interleaved with XCTest output would cause false positives, leading users to believe that their test never completed (crashed) when really we just missed the success/failure message from XCTest due to overly strict parsing. Relax the XCTest output parsing regexes so that matched strings don't need to be at the start of a line.
plemarquand
added a commit
that referenced
this pull request
Apr 22, 2025
Sometimes when running tests that print user output during their execution this output can be printed on the same line as XCTest results output, either before or after the results string. Previously this showed as a test that never finished (pending) in then test explorer, but with the introduction of #1505 tests that start but don't find any completion output are assumed to be crashed and marked as failed. This extra user output interleaved with XCTest output would cause false positives, leading users to believe that their test never completed (crashed) when really we just missed the success/failure message from XCTest due to overly strict parsing. Relax the XCTest output parsing regexes so that matched strings don't need to be at the start of a line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test crashes during a test run the extension never marks the test as failed, since it doesn't see the output that marks the test as completed.
If we finish a test run and we still have a test in the 'pending' state where no pass/fail/skip has been seen, mark the test as failed with a message stating the test never finished.
Issue: #1504