Fix Search Subfolders For Packages Not Working in Swift Package Workspaces #1425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdelmagied94
requested review from
0xTim,
adam-fowler and
award999
as code owners
plemarquand
reviewed
Mar 9, 2025
Contributor
plemarquand
left a comment
plemarquand
left a comment
There was a problem hiding this comment.
Thanks for the patch with detailed tests! I'll check out the code and try it out tomorrow. I have just a couple of nitpick comments.
Also, the windows CI failures are expected at the moment.
plemarquand
approved these changes
Mar 10, 2025
Contributor
plemarquand
left a comment
plemarquand
left a comment
There was a problem hiding this comment.
I tried this out and it looks good to me, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling the
searchSubfoldersForPackagesflag didn't work when the workspace folder was a valid Swift Package. This issue occurred due to an earlyreturnstatement that prevented further search. This PR resolves the issue by removing the prematurereturnand refactoring the related logic into a utility. Additionally, unit tests have been added to ensure correct behavior.