Skip to content

Remove numpy dependency #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2016
Merged

Remove numpy dependency #989

merged 1 commit into from
Jan 21, 2016

Conversation

practicalswift
Copy link
Contributor

No description provided.

@modocache
Copy link
Contributor

Wow, from what I understand numpy is not a light dependency. This change seems well worth the two extra lines. Thanks, @practicalswift!

@practicalswift
Copy link
Contributor Author

@modocache Yes, numpy is quite heavy - it is roughly 265 000 lines of code 😄

@mxcl
Copy link

mxcl commented Jan 19, 2016

This is the kind of unrecognized but important contribution that helps big projects stay lean 👏

@jrose-apple
Copy link
Contributor

@nadavrot, is anyone even using this script? It hasn't been updated in a long time, but I can't tell if that's because it's unused or because it's simple and working as is.

@nadavrot
Copy link
Contributor

I think that Andy and Arnold are using this script (based on the output of their reports).

On Jan 21, 2016, at 10:19 AM, Jordan Rose notifications@github.com wrote:

@nadavrot https://github.com/nadavrot, is anyone even using this script? It hasn't been updated in a long time, but I can't tell if that's because it's unused or because it's simple and working as is.


Reply to this email directly or view it on GitHub #989 (comment).

@jrose-apple
Copy link
Contributor

Okay. Any objections, @atrick, @aschwaighofer?

(I assume this is almost automatically a desireable change but the script doesn't exactly have an owner right now.)

atrick added a commit that referenced this pull request Jan 21, 2016
@atrick atrick merged commit 8afab35 into swiftlang:master Jan 21, 2016
@atrick
Copy link
Contributor

atrick commented Jan 21, 2016

I've never used numpy!

MaxDesiatov added a commit to MaxDesiatov/swift that referenced this pull request May 14, 2020
Add CMake toolchain for cross-compiling Swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants