Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDE] Preserve order for Clang declarations with the same source loc. #9581

Merged
merged 1 commit into from
May 14, 2017

Conversation

jrose-apple
Copy link
Contributor

This usually indicates the same declaration being imported multiple ways; trust the ClangImporter to provide a reasonable order for these.

Necessary to get consistent behavior for my next PR across Mac and Linux.

This usually indicates the same declaration being imported multiple
ways; trust the ClangImporter to provide a reasonable order for these.
@jrose-apple jrose-apple requested review from akyrtzi and nkcsgexi May 13, 2017 23:14
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

Maybe I should test iOS too.

@swift-ci Please test macOS

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrose-apple jrose-apple merged commit 4674ad5 into swiftlang:master May 14, 2017
@jrose-apple jrose-apple deleted the stable_sort-Clang-decls branch May 14, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants