Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggested directory names for XCTest and Foundation repositories #91

Closed
wants to merge 1 commit into from

Conversation

manyoso
Copy link
Contributor

@manyoso manyoso commented Dec 3, 2015

in the manner expected by the build-script

@cwillmor
Copy link
Contributor

cwillmor commented Dec 3, 2015

The correct names for these directories in the source tree are "swift-corelibs-foundation" and "swift-corelibs-xctest"; the comment in utils/build-script:144-145 to the contrary is out of date. Feel free to fix that instead. Cf. 32f8492

@cwillmor cwillmor closed this Dec 3, 2015
@cwillmor cwillmor reopened this Dec 3, 2015
@manyoso manyoso closed this Dec 3, 2015
DougGregor added a commit to DougGregor/swift that referenced this pull request Apr 20, 2017
…swiftlang#90, swiftlang#91.

Address ABI FIXME swiftlang#68 by using same-type constraints directly on an
associated type to describe the requirements on the Indices associated
type of the Collection protocol. ABI FIXMEs swiftlang#89, swiftlang#90, swiftlang#91 are all in
StdlibUnittest, and provoke warnings once swiftlang#68 is fixed, but it's nice
to clear them out.

Fixes SR-2121.
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Aug 2, 2018
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Sep 17, 2018
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
Helper methods to modify leading and trailing trivia on nodes
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
DougGregor pushed a commit to DougGregor/swift that referenced this pull request Apr 28, 2024
windows: update toolchain manifest for swift-argument-parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants