Skip to content

Conversation

@charles-zablit
Copy link
Contributor

This patch moves the file windows-llvm-lit-test-overrides.txt from swiftlang/swift to swiftlang/llvm-project.

As it controls the failing and skipped tests of LLVM, this will make it easier to remove tests that are no longer failing as we improve the test coverage of LLDB on Windows.

This should be merged after swiftlang/llvm-project#11143.

Copy link
Member

@weliveindetail weliveindetail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

utils/build.ps1 Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the new name should reflect that the overrides are Swift specific

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks! This is now windows-swift-llvm-lit-test-overrides.txt

@charles-zablit charles-zablit force-pushed the charles-zablit/windows/move-llvm-overrides-to-llvm-repo branch from ec1a0fe to 312ac1b Compare August 7, 2025 13:38
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems reasonable enough

@charles-zablit
Copy link
Contributor Author

@swift-ci please smoke test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit force-pushed the charles-zablit/windows/move-llvm-overrides-to-llvm-repo branch from 312ac1b to 873cb00 Compare August 21, 2025 16:30
@charles-zablit
Copy link
Contributor Author

@swift-ci please smoke test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

1 similar comment
@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit force-pushed the charles-zablit/windows/move-llvm-overrides-to-llvm-repo branch from 873cb00 to 2ecb65d Compare September 1, 2025 14:05
@charles-zablit
Copy link
Contributor Author

@swift-ci please test

@charles-zablit
Copy link
Contributor Author

@swift-ci please smoke test

@charles-zablit
Copy link
Contributor Author

@swift-ci please test macOS

@charles-zablit
Copy link
Contributor Author

@swift-ci please test windows

@charles-zablit charles-zablit merged commit ca35ad7 into swiftlang:main Sep 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Windows Platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants