[stdlib] [SR-4005] Allow heterogenous comparisons in elementsEqual #8045

Cbieniak · 2017-03-13T11:14:45Z

When supplying a predicate to compare, type equivalence of the two sequences are not necessary

Cbieniak · 2017-03-13T11:16:47Z

@swift-ci Please smoke test

jrose-apple · 2017-03-13T23:33:51Z

stdlib/public/core/SequenceAlgorithms.swift.gyb

 %   end
  ) ${rethrows_}-> Bool
    where
-    OtherSequence: Sequence,
+    OtherSequence: Sequence${" {" if preds else ","}
+%   if not preds:
    OtherSequence.${GElement} == ${GElement} {


@nkcsgexi It is concerning that the change in the generic requirements was not caught by swift-api-digester.

Right, the diff tool is not comparing generic requirements now.

airspeedswift · 2017-04-21T13:11:50Z

@swift-ci Please test

airspeedswift

Could you add some changes to test some comparisons of different element types using a closure? (for example, comparing ["0","1","2"] to 0..<4)

Cbieniak · 2017-05-12T05:25:36Z

@airspeedswift I've written a couple comparing the string version of ints being converted. Is this appropriate?

Cbieniak · 2017-06-05T04:47:38Z

@swift-ci Please test

jrose-apple · 2017-06-05T16:44:15Z

@swift-ci Please test

jrose-apple · 2017-06-05T16:44:21Z

@swift-ci Please test source compatibility

swift-ci · 2017-06-05T17:00:47Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ddb3265
Test requested by - @jrose-apple

Cbieniak · 2017-06-06T07:54:55Z

@jrose-apple thanks for the review. The only error I could see in the linux build was

TestFoundation/TestNSURLSession.swift:245: error: TestURLSession.test_downloadTaskWithURLAndHandler : XCTAssertEqual failed: ("cannotConnectToHost") is not equal to ("timedOut") - Unexpected error code

my best guess would be that its an issue with the linux instance rather than the pr, Should we just rerun the tests or did you have advice on how id go about fixing this?

jrose-apple · 2017-06-07T20:51:08Z

Ah, yeah, seems unlikely. Let's try again.

(This still isn't a review, though. @airspeedswift needs to accept the new version.)

@swift-ci Please test Linux platform

airspeedswift · 2017-10-02T22:28:18Z

@swift-ci please test and merge

jrose-apple · 2017-10-02T22:33:01Z

@swift-ci Please test source compatibility

airspeedswift · 2017-10-02T23:08:31Z

Oops, thanks @jrose. Tho it'd be pretty weird if this caused anything to fail.

airspeedswift · 2017-10-02T23:08:49Z

@swift-ci please clean test linux platform

swift-ci · 2017-10-02T23:31:56Z

Build failed
Swift Test Linux Platform
Git Sha - ddb3265

jrose-apple · 2017-10-02T23:57:01Z

The compat suite failures are in AsyncNinja, which we think is due to Pavel's recent change. Not related to this commit.

airspeedswift · 2017-10-03T22:42:23Z

Hi @Cbieniak – sorry, looks like I just caused a conflict with another commit. Could you rebase and hopefully we can land this? Thanks!

When a user is supplying a predicate to compare the type equivalence isn’t required

Compares a string of a number with an integer value by using the elementsEqualPredicate closure

Cbieniak · 2017-10-04T10:51:44Z

@airspeedswift No worries at all mate.

airspeedswift · 2017-10-05T19:53:09Z

@swift-ci please test

airspeedswift · 2017-10-05T19:53:26Z

@swift-ci please smoke test compiler performance

airspeedswift · 2017-10-05T19:53:33Z

@swift-ci please test source compatibility

swift-ci · 2017-10-05T22:26:02Z

Build comment file:

Summary for master smoketest

Regressions found (see below)

Debug
- PR vs. head (debug)
  - PR vs. head, changed counters (debug)
  - PR vs. head, changed timers (debug)
- PR vs. baseline (debug)
  - PR vs. baseline, changed counters (debug)
  - PR vs. baseline, changed timers (debug)
Release
- PR vs. head (release)
  - PR vs. head, changed counters (release)
  - PR vs. head, changed timers (release)
- PR vs. baseline (release)
  - PR vs. baseline, changed counters (release)
  - PR vs. baseline, changed timers (release)

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

name	old	new	delta	delta_pct

PR vs. head, changed timers (debug)

name	old	new	delta	delta_pct

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

name	old	new	delta	delta_pct
ReactiveCocoa LLVM.NumLLVMBytesOutput	4779068	6483384	1704316	35.66 ⛔
ReactiveCocoa Sema.NumConstraintScopes	42990	56900	13910	32.36 ⛔
Alamofire Sema.NumConformancesDeserialized	31066	35526	4460	14.36 ⛔
ReactiveCocoa Sema.NumLazyGenericEnvironments	90668	102354	11686	12.89 ⛔
ReactiveCocoa Sema.NumDeclsDeserialized	494586	536571	41985	8.49 ⛔
Alamofire SILModule.NumSILOptFunctions	3908	4236	328	8.39 ⛔
Kingfisher SILModule.NumSILOptFunctions	7512	8109	597	7.95 ⛔
ReactiveCocoa SILModule.NumSILOptFunctions	4068	4306	238	5.85 ⛔
ReactiveSwift Sema.NumLazyGenericEnvironments	50700	53598	2898	5.72 ⛔
Kingfisher LLVM.NumLLVMBytesOutput	4703184	4933564	230380	4.9 ⛔
ReactiveSwift Sema.NumDeclsDeserialized	291650	304789	13139	4.51 ⛔
ReactiveCocoa Sema.NumTypesDeserialized	447708	463702	15994	3.57 ⛔
ReactiveSwift SILModule.NumSILOptFunctions	6970	7212	242	3.47 ⛔
ReactiveSwift LLVM.NumLLVMBytesOutput	8051308	8314056	262748	3.26 ⛔
Alamofire Sema.NumDeclsDeserialized	192907	198679	5772	2.99 ⛔
Alamofire Sema.NumLazyGenericEnvironments	29706	30331	625	2.1 ⛔
Kingfisher Sema.NumLazyGenericEnvironments	65820	66558	738	1.12 ⛔
ReactiveSwift Sema.NumTypesDeserialized	253214	255480	2266	0.89 ⛔
Kingfisher Sema.NumDeclsDeserialized	406293	409549	3256	0.8 ⛔
Alamofire LLVM.NumLLVMBytesOutput	2996100	`3019724`	23624	0.79 ⛔
ReactiveSwift IRModule.NumIRGlobals	12388	12426	38	0.31 ⛔
ReactiveCocoa IRModule.NumIRGlobals	9536	9534	-2	-0.02 ✅
Alamofire Sema.NumTypesDeserialized	158803	158698	-105	-0.07 ✅
Kingfisher SILModule.NumSILGenFunctions	4186	4182	-4	-0.1 ✅
Alamofire SILModule.NumSILGenFunctions	2463	2460	-3	-0.12 ✅
ReactiveSwift SILModule.NumSILGenFunctions	4833	4819	-14	-0.29 ✅
ReactiveCocoa SILModule.NumSILGenFunctions	2904	2894	-10	-0.34 ✅
ReactiveCocoa AST.NumUsedConformances	704	700	-4	-0.57 ✅
Alamofire AST.NumUsedConformances	435	432	-3	-0.69 ✅
Kingfisher IRModule.NumIRGlobals	9117	9053	-64	-0.7 ✅
ReactiveCocoa Sema.NumLazyGenericEnvironmentsLoaded	10174	10090	-84	-0.83 ✅
ReactiveCocoa AST.NumTotalClangImportedEntities	101754	100824	-930	-0.91 ✅
Kingfisher AST.NumUsedConformances	858	850	-8	-0.93 ✅
Alamofire IRModule.NumIRGlobals	4765	4713	-52	-1.09 ✅
ReactiveSwift AST.NumUsedConformances	730	722	-8	-1.1 ✅
ReactiveCocoa IRModule.NumIRValueSymbols	14686	14472	-214	-1.46 ✅
Alamofire Sema.NumFunctionsTypechecked	5545	5454	-91	-1.64 ✅
ReactiveCocoa Sema.NumFunctionsTypechecked	18516	18200	-316	-1.71 ✅
ReactiveCocoa Sema.NumLazyIterableDeclContexts	105954	104146	-1808	-1.71 ✅
ReactiveSwift IRModule.NumIRValueSymbols	19619	19283	-336	-1.71 ✅
ReactiveCocoa AST.NumImportedExternalDefinitions	34112	33388	-724	-2.12 ✅
Kingfisher Sema.NumTypesDeserialized	344365	336495	-7870	-2.29 ✅
Alamofire Sema.NumLazyIterableDeclContexts	21455	20960	-495	-2.31 ✅
Kingfisher Sema.NumLazyGenericEnvironmentsLoaded	5480	5336	-144	-2.63 ✅
ReactiveCocoa IRModule.NumIRFunctions	7080	6878	-202	-2.85 ✅
Kingfisher Sema.NumLazyIterableDeclContexts	54859	53284	-1575	-2.87 ✅
ReactiveSwift IRModule.NumIRFunctions	10863	10537	-326	-3.0 ✅
ReactiveSwift Sema.NumLazyGenericEnvironmentsLoaded	7646	7416	-230	-3.01 ✅
ReactiveSwift Sema.NumLazyIterableDeclContexts	37546	36395	-1151	-3.07 ✅
ReactiveSwift Sema.NumFunctionsTypechecked	4538	4398	-140	-3.09 ✅
ReactiveCocoa IRModule.NumIRInsts	102753	99493	-3260	-3.17 ✅
ReactiveCocoa IRModule.NumIRBasicBlocks	11870	11490	-380	-3.2 ✅
Alamofire IRModule.NumIRValueSymbols	8767	8470	-297	-3.39 ✅
Kingfisher IRModule.NumIRValueSymbols	14986	14464	-522	-3.48 ✅
ReactiveSwift Sema.NumConformancesDeserialized	49822	48022	-1800	-3.61 ✅
Alamofire IRModule.NumIRFunctions	5357	5119	-238	-4.44 ✅
Kingfisher IRModule.NumIRInsts	194978	184655	-10323	-5.29 ✅
ReactiveSwift IRModule.NumIRInsts	332161	314104	-18057	-5.44 ✅
Alamofire Sema.NumConstraintScopes	43672	41279	-2393	-5.48 ✅
Kingfisher IRModule.NumIRFunctions	8204	7754	-450	-5.49 ✅
Alamofire Sema.NumLazyGenericEnvironmentsLoaded	2641	2493	-148	-5.6 ✅
Kingfisher IRModule.NumIRBasicBlocks	18956	17889	-1067	-5.63 ✅
Kingfisher Sema.NumConformancesDeserialized	70852	66860	-3992	-5.63 ✅
Alamofire AST.NumImportedExternalDefinitions	8501	7982	-519	-6.11 ✅
Kingfisher Sema.NumFunctionsTypechecked	17534	16432	-1102	-6.28 ✅
ReactiveCocoa Sema.NumConformancesDeserialized	57916	53422	-4494	-7.76 ✅
Alamofire IRModule.NumIRBasicBlocks	15117	13942	-1175	-7.77 ✅
Alamofire IRModule.NumIRInsts	145724	134199	-11525	-7.91 ✅
Kingfisher AST.NumImportedExternalDefinitions	28988	26636	-2352	-8.11 ✅
ReactiveSwift Sema.NumConstraintScopes	41650	37766	-3884	-9.33 ✅
Alamofire AST.NumTotalClangImportedEntities	27881	24816	-3065	-10.99 ✅
Kingfisher AST.NumTotalClangImportedEntities	75188	66040	-9148	-12.17 ✅
ReactiveSwift IRModule.NumIRBasicBlocks	21814	19086	-2728	-12.51 ✅
ReactiveSwift AST.NumImportedExternalDefinitions	6434	5566	-868	-13.49 ✅
ReactiveCocoa Sema.NumTypesValidated	49050	40968	-8082	-16.48 ✅
ReactiveSwift Sema.NumTypesValidated	100770	81156	-19614	-19.46 ✅
Alamofire Sema.NumTypesValidated	18298	14335	-3963	-21.66 ✅
Kingfisher Sema.NumTypesValidated	27944	21406	-6538	-23.4 ✅
ReactiveCocoa Sema.NumDeclsValidated	106644	81026	-25618	-24.02 ✅
ReactiveSwift AST.NumTotalClangImportedEntities	24796	18652	-6144	-24.78 ✅
Kingfisher Sema.NumDeclsValidated	125016	83066	-41950	-33.56 ✅
Alamofire Sema.NumDeclsValidated	61341	38708	-22633	-36.9 ✅
ReactiveCocoa Sema.NumGenericSignatureBuilders	49468	28598	-20870	-42.19 ✅
ReactiveSwift Sema.NumDeclsValidated	75348	42528	-32820	-43.56 ✅
Kingfisher Sema.NumConstraintScopes	581970	316772	-265198	-45.57 ✅
ReactiveSwift Sema.NumGenericSignatureBuilders	31134	15918	-15216	-48.87 ✅
Kingfisher Sema.NumGenericSignatureBuilders	33750	14639	-19111	-56.63 ✅
Alamofire Sema.NumGenericSignatureBuilders	13996	5572	-8424	-60.19 ✅

PR vs. baseline, changed timers (debug)

name	old	new	delta	delta_pct

Release

PR vs. head (release)

PR vs. head, changed counters (release)

name	old	new	delta	delta_pct

PR vs. head, changed timers (release)

name	old	new	delta	delta_pct

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

name	old	new	delta	delta_pct
ReactiveCocoa Sema.NumConstraintScopes	23810	38104	14294	60.03 ⛔
ReactiveCocoa LLVM.NumLLVMBytesOutput	5481964	8760228	3278264	59.8 ⛔
Alamofire AST.NumTotalClangImportedEntities	2920	3234	314	10.75 ⛔
Kingfisher LLVM.NumLLVMBytesOutput	5463388	5948788	485400	8.88 ⛔
Kingfisher AST.NumTotalClangImportedEntities	9086	9816	730	8.03 ⛔
ReactiveSwift LLVM.NumLLVMBytesOutput	9453100	10095456	642356	6.8 ⛔
Alamofire LLVM.NumLLVMBytesOutput	3172424	3354676	182252	5.74 ⛔
ReactiveCocoa SILModule.NumSILOptFunctions	2915	3025	110	3.77 ⛔
ReactiveCocoa AST.NumTotalClangImportedEntities	7270	7434	164	2.26 ⛔
Alamofire SILModule.NumSILOptFunctions	2991	3018	27	0.9 ⛔
ReactiveSwift IRModule.NumIRGlobals	11628	11722	94	0.81 ⛔
Kingfisher SILModule.NumSILOptFunctions	5723	5760	37	0.65 ⛔
Kingfisher IRModule.NumIRGlobals	8627	8672	45	0.52 ⛔
ReactiveCocoa IRModule.NumIRGlobals	8486	8494	8	0.09 ⛔
Alamofire SILModule.NumSILGenFunctions	1861	1860	-1	-0.05 ✅
ReactiveCocoa SILModule.NumSILGenFunctions	1917	1915	-2	-0.1 ✅
ReactiveSwift SILModule.NumSILOptFunctions	6852	6821	-31	-0.45 ✅
ReactiveSwift SILModule.NumSILGenFunctions	3755	3737	-18	-0.48 ✅
Alamofire IRModule.NumIRGlobals	4521	4496	-25	-0.55 ✅
ReactiveSwift AST.NumUsedConformances	732	728	-4	-0.55 ✅
ReactiveCocoa AST.NumUsedConformances	704	700	-4	-0.57 ✅
ReactiveCocoa Sema.NumLazyGenericEnvironments	6206	6166	-40	-0.64 ✅
Alamofire AST.NumUsedConformances	435	432	-3	-0.69 ✅
ReactiveSwift Sema.NumFunctionsTypechecked	1990	1976	-14	-0.7 ✅
ReactiveSwift Sema.NumLazyGenericEnvironments	5192	5144	-48	-0.92 ✅
Kingfisher AST.NumUsedConformances	858	850	-8	-0.93 ✅
Kingfisher Sema.NumDeclsDeserialized	48966	48185	-781	-1.59 ✅
ReactiveCocoa IRModule.NumIRValueSymbols	12322	12104	-218	-1.77 ✅
ReactiveSwift IRModule.NumIRValueSymbols	19993	19626	-367	-1.84 ✅
Alamofire Sema.NumLazyGenericEnvironments	2812	2756	-56	-1.99 ✅
ReactiveCocoa Sema.NumDeclsDeserialized	42725	41848	-877	-2.05 ✅
ReactiveCocoa Sema.NumTypesDeserialized	39744	38884	-860	-2.16 ✅
ReactiveSwift Sema.NumDeclsDeserialized	44916	43907	-1009	-2.25 ✅
ReactiveCocoa Sema.NumLazyIterableDeclContexts	3880	3792	-88	-2.27 ✅
Kingfisher Sema.NumTypesDeserialized	46202	45064	-1138	-2.46 ✅
Alamofire Sema.NumDeclsDeserialized	24868	24130	-738	-2.97 ✅
Kingfisher Sema.NumLazyIterableDeclContexts	3642	3531	-111	-3.05 ✅
Alamofire Sema.NumLazyIterableDeclContexts	1716	1663	-53	-3.09 ✅
ReactiveSwift IRModule.NumIRInsts	271570	263013	-8557	-3.15 ✅
ReactiveSwift Sema.NumTypesDeserialized	40951	39649	-1302	-3.18 ✅
Kingfisher IRModule.NumIRValueSymbols	13308	12875	-433	-3.25 ✅
Alamofire Sema.NumTypesDeserialized	23829	23030	-799	-3.35 ✅
Alamofire IRModule.NumIRValueSymbols	7218	6965	-253	-3.51 ✅
ReactiveSwift IRModule.NumIRFunctions	10605	10216	-389	-3.67 ✅
ReactiveSwift Sema.NumConformancesDeserialized	26845	25798	-1047	-3.9 ✅
ReactiveSwift Sema.NumLazyIterableDeclContexts	2982	2861	-121	-4.06 ✅
ReactiveCocoa IRModule.NumIRFunctions	5090	4876	-214	-4.2 ✅
Kingfisher Sema.NumLazyGenericEnvironments	5170	4938	-232	-4.49 ✅
ReactiveCocoa IRModule.NumIRInsts	69895	66747	-3148	-4.5 ✅
Alamofire IRModule.NumIRInsts	123248	117465	-5783	-4.69 ✅
ReactiveCocoa Sema.NumLazyGenericEnvironmentsLoaded	728	692	-36	-4.95 ✅
Alamofire Sema.NumLazyGenericEnvironmentsLoaded	383	363	-20	-5.22 ✅
Alamofire IRModule.NumIRFunctions	3819	3599	-220	-5.76 ✅
Alamofire Sema.NumConstraintScopes	38683	36446	-2237	-5.78 ✅
Kingfisher Sema.NumLazyGenericEnvironmentsLoaded	876	824	-52	-5.94 ✅
Alamofire IRModule.NumIRBasicBlocks	16869	15771	-1098	-6.51 ✅
ReactiveSwift Sema.NumLazyGenericEnvironmentsLoaded	890	832	-58	-6.52 ✅
ReactiveCocoa Sema.NumConformancesDeserialized	20926	19558	-1368	-6.54 ✅
ReactiveCocoa IRModule.NumIRBasicBlocks	9437	8757	-680	-7.21 ✅
Kingfisher IRModule.NumIRFunctions	6265	5807	-458	-7.31 ✅
ReactiveSwift IRModule.NumIRBasicBlocks	23918	22073	-1845	-7.71 ✅
Kingfisher Sema.NumConformancesDeserialized	30795	28342	-2453	-7.97 ✅
ReactiveSwift Sema.NumConstraintScopes	38598	34930	-3668	-9.5 ✅
Kingfisher IRModule.NumIRInsts	189828	170741	-19087	-10.05 ✅
Kingfisher IRModule.NumIRBasicBlocks	25356	22751	-2605	-10.27 ✅
ReactiveSwift Sema.NumTypesValidated	26352	23594	-2758	-10.47 ✅
Alamofire Sema.NumConformancesDeserialized	16433	14598	-1835	-11.17 ✅
ReactiveSwift AST.NumImportedExternalDefinitions	592	512	-80	-13.51 ✅
Alamofire Sema.NumTypesValidated	1977	1592	-385	-19.47 ✅
ReactiveSwift AST.NumTotalClangImportedEntities	2670	2102	-568	-21.27 ✅
Kingfisher Sema.NumTypesValidated	3794	2740	-1054	-27.78 ✅
ReactiveCocoa Sema.NumTypesValidated	4072	2372	-1700	-41.75 ✅
ReactiveSwift Sema.NumGenericSignatureBuilders	4390	2390	-2000	-45.56 ✅
ReactiveCocoa Sema.NumDeclsValidated	20206	10966	-9240	-45.73 ✅
Kingfisher Sema.NumConstraintScopes	564928	301082	-263846	-46.7 ✅
ReactiveCocoa Sema.NumGenericSignatureBuilders	3612	1854	-1758	-48.67 ✅
Alamofire Sema.NumGenericSignatureBuilders	1595	687	-908	-56.93 ✅
Kingfisher Sema.NumGenericSignatureBuilders	3925	1599	-2326	-59.26 ✅
Kingfisher Sema.NumDeclsValidated	35702	14416	-21286	-59.62 ✅
Alamofire Sema.NumDeclsValidated	17283	6831	-10452	-60.48 ✅
ReactiveSwift Sema.NumDeclsValidated	28656	9610	-19046	-66.46 ✅

PR vs. baseline, changed timers (release)

name	old	new	delta	delta_pct

Last baseline commit on smoketest-master-debug.csv

commit 87209ce76c9cb2ac66f7c70383b4179b880718fb
Author: Graydon Hoare 
Date:   Tue Oct 3 23:51:30 2017 -0700

    [cperf-baselines] Reset to swift-4.0-DEVELOPMENT-SNAPSHOT-2017-09-23-a, after last set of stats fixes.

Last baseline commit on smoketest-master-release.csv

commit 87209ce76c9cb2ac66f7c70383b4179b880718fb
Author: Graydon Hoare 
Date:   Tue Oct 3 23:51:30 2017 -0700

    [cperf-baselines] Reset to swift-4.0-DEVELOPMENT-SNAPSHOT-2017-09-23-a, after last set of stats fixes.

airspeedswift · 2017-10-06T18:55:13Z

Ah. Looks like one of the hardcoded tests that check completion needs tweaking.

airspeedswift · 2017-11-07T18:47:54Z

@swift-ci please test

swift-ci · 2017-11-07T19:13:01Z

Build failed
Swift Test Linux Platform
Git Sha - abf2633

swift-ci · 2017-11-07T19:40:01Z

Build failed
Swift Test OS X Platform
Git Sha - abf2633

Cbieniak · 2017-11-08T02:36:23Z

Looks like an issue with the complete_from_stdlib.swift. Ill fix it when I get a chance

airspeedswift · 2017-11-08T21:04:58Z

Thanks @Cbieniak!

Cbieniak · 2017-11-28T09:29:35Z

Should be all sorted now

airspeedswift · 2017-11-29T21:45:30Z

@swift-ci please test

airspeedswift · 2017-11-30T01:05:09Z

@swift-ci please test macOS platform

CodaFi requested a review from airspeedswift March 13, 2017 22:43

jrose-apple reviewed Mar 13, 2017

View reviewed changes

airspeedswift requested changes Apr 21, 2017

View reviewed changes

Cbieniak force-pushed the fix/SR-4005 branch from df8952e to 9ca729f Compare April 30, 2017 07:07

Cbieniak force-pushed the fix/SR-4005 branch from f6ae10c to ddb3265 Compare June 3, 2017 04:20

airspeedswift self-assigned this Jun 21, 2017

airspeedswift approved these changes Oct 2, 2017

View reviewed changes

Cbieniak force-pushed the fix/SR-4005 branch from ddb3265 to 1a760ca Compare October 4, 2017 10:14

Cbieniak added 3 commits October 4, 2017 21:38

[SR-4005] Allow heterogenous comparisons in elementsEqual

4f3daca

When a user is supplying a predicate to compare the type equivalence isn’t required

elementsEqualWithPredicate tests

f05b394

Compares a string of a number with an integer value by using the elementsEqualPredicate closure

Update test expectations to use new sequence element types

abf2633

Cbieniak force-pushed the fix/SR-4005 branch from 1a760ca to abf2633 Compare October 4, 2017 10:42

swiftlang deleted a comment from swift-ci Oct 5, 2017

Update hardcoded test to reference sequence

211a338

airspeedswift merged commit ec0d53f into swiftlang:master Nov 30, 2017

Cbieniak mentioned this pull request Mar 20, 2017

[SR-4005] elementsEqual should allow heterogenous comparisons #46590

Closed

[stdlib] [SR-4005] Allow heterogenous comparisons in elementsEqual #8045

[stdlib] [SR-4005] Allow heterogenous comparisons in elementsEqual #8045

Conversation

Cbieniak commented Mar 13, 2017

Cbieniak commented Mar 13, 2017

jrose-apple Mar 13, 2017

Choose a reason for hiding this comment

nkcsgexi Apr 21, 2017

Choose a reason for hiding this comment

airspeedswift commented Apr 21, 2017

airspeedswift left a comment

Choose a reason for hiding this comment

Cbieniak commented May 12, 2017

Cbieniak commented Jun 5, 2017

jrose-apple commented Jun 5, 2017

jrose-apple commented Jun 5, 2017

swift-ci commented Jun 5, 2017

Cbieniak commented Jun 6, 2017

jrose-apple commented Jun 7, 2017

airspeedswift commented Oct 2, 2017

jrose-apple commented Oct 2, 2017

airspeedswift commented Oct 2, 2017

airspeedswift commented Oct 2, 2017

swift-ci commented Oct 2, 2017

jrose-apple commented Oct 2, 2017

airspeedswift commented Oct 3, 2017

Cbieniak commented Oct 4, 2017

airspeedswift commented Oct 5, 2017

airspeedswift commented Oct 5, 2017

airspeedswift commented Oct 5, 2017

swift-ci commented Oct 5, 2017

Build comment file:

Summary for master smoketest

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

PR vs. head, changed timers (debug)

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

PR vs. baseline, changed timers (debug)

Release

PR vs. head (release)

PR vs. head, changed counters (release)

PR vs. head, changed timers (release)

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

PR vs. baseline, changed timers (release)

airspeedswift commented Oct 6, 2017

airspeedswift commented Nov 7, 2017

swift-ci commented Nov 7, 2017

swift-ci commented Nov 7, 2017

Cbieniak commented Nov 8, 2017

airspeedswift commented Nov 8, 2017

Cbieniak commented Nov 28, 2017

airspeedswift commented Nov 29, 2017

airspeedswift commented Nov 30, 2017