[IDE] Complete nonisolated, unowned, and access control attribute parameter

[a7medev]

Description

Added code completion support for:

• nonisolated(unsafe)
• unowned(safe)
• unowned(unsafe)
• <access-control>(set) (e.g. private(set))

[ahoppen]

This is a great PR. Thank you, @a7medev 🙏🏽

I left a few comments inline. The next steps would be to add some tests for these new completions in test/IDE.

[a7medev]

@ahoppen Thanks for the thorough review. 🙏🏼 I've addressed the added comments and added the tests.
Can you please re-review the PR? 🙏🏼

[ahoppen]

Thanks for adding the tests as well. Two more minor comments, otherwise this looks great to me.

[a7medev]

@ahoppen I've addressed the added comments. Can you please re-review? 🙏🏼

[ahoppen]

Thank you. Looks good to me. I’ll trigger CI and if it passes, I’ll merge the PR.

[ahoppen]

@swift-ci Please smoke test

[a7medev]

@ahoppen I see the CI jobs for Linux and Windows are failing. I checked the output and found a similar error for both of them: "error: cannot find 'PollIndexRequest' in scope" in BackgroundIndexingTests.swift for SourceKit LSP. I'm not sure exactly what's the cause for it but looking at other PRs I found some CI failures with the same error so I'm suspecting it's either flaky or missing some kind of configuration. What do you think?

[ahoppen]

The failure should be gone with swiftlang/swift-integration-tests#156.

[ahoppen]

@swift-ci Please smoke test Linux

[ahoppen]

@swift-ci Please test Windows