Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Update InlineArray #79800

Merged
merged 6 commits into from
Mar 8, 2025
Merged

Conversation

benrimmington
Copy link
Contributor

@benrimmington benrimmington commented Mar 5, 2025

Updates documentation, and adds missing APIs from the proposal.
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0453-vector.md

FIXME: Empty array literals aren't supported.

@benrimmington benrimmington force-pushed the inline-array branch 2 times, most recently from a25b821 to 385c543 Compare March 6, 2025 08:15
- Write an overview of the type.
- Amend summaries of the initializers.
- Remove inapplicable example code.
- Add "Complexity: O(*n*)" to initializers.
- Add "Complexity: O(1)" to indexing APIs.
- Add FIXME comments.
FIXME: Empty array literals aren't supported.
@benrimmington benrimmington marked this pull request as ready for review March 6, 2025 23:45
@benrimmington benrimmington requested a review from a team as a code owner March 6, 2025 23:45
Copy link
Contributor

@Azoy Azoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies I haven't been able to get around to this yet. Thank you!

@benrimmington
Copy link
Contributor Author

@swift-ci Please smoke test

@benrimmington benrimmington enabled auto-merge March 7, 2025 20:34
@benrimmington benrimmington merged commit e5487d8 into swiftlang:main Mar 8, 2025
3 checks passed
@benrimmington benrimmington deleted the inline-array branch March 8, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants