Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concurrency] Initial steps for startSynchronously for Task #79608

Merged
merged 11 commits into from
Feb 27, 2025

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Feb 25, 2025

Some initial work to start off the work on startSynchronously.

The implementation is wrong for tasks coming from outside any task hierarchy and calling into actors keeps reusing the context which it must not.

Part of rdar://134542575

@ktoso ktoso requested review from rjmccall and a team as code owners February 25, 2025 14:34
@ktoso
Copy link
Contributor Author

ktoso commented Feb 25, 2025

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-initial-tast-sync-start branch from eb26e94 to b47a037 Compare February 26, 2025 03:39
@ktoso
Copy link
Contributor Author

ktoso commented Feb 26, 2025

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-initial-tast-sync-start branch 2 times, most recently from 7ee0a54 to 5787a25 Compare February 26, 2025 08:13
@ktoso ktoso enabled auto-merge (squash) February 26, 2025 08:25
@ktoso ktoso force-pushed the wip-initial-tast-sync-start branch from 5787a25 to 56f28ee Compare February 26, 2025 08:29
@ktoso ktoso disabled auto-merge February 26, 2025 08:31
@ktoso
Copy link
Contributor Author

ktoso commented Feb 26, 2025

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Feb 26, 2025

DispatchSerialQueue does not exist on linux still... fixed up.

@ktoso ktoso force-pushed the wip-initial-tast-sync-start branch from e1584bf to 329c710 Compare February 26, 2025 13:03
@ktoso ktoso enabled auto-merge (squash) February 26, 2025 13:17
@ktoso ktoso force-pushed the wip-initial-tast-sync-start branch from 329c710 to 65cd32e Compare February 26, 2025 13:35
@ktoso
Copy link
Contributor Author

ktoso commented Feb 26, 2025

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Feb 27, 2025

@swift-ci please smoke test

1 similar comment
@ktoso
Copy link
Contributor Author

ktoso commented Feb 27, 2025

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Feb 27, 2025

mac build timeout 😢

Cancelling nested steps due to timeout

@swift-ci please smoke test macOS

@ktoso ktoso merged commit f55964d into swiftlang:main Feb 27, 2025
3 checks passed
@ktoso ktoso deleted the wip-initial-tast-sync-start branch February 28, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant