[BridgingHeader] Fix auto-chaining when only dependency has bridging header #79301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
cachemeifyoucan
force-pushed
the
eng/PR-144623388
branch
from
7881bf7 to
3af2d83
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
…header When enable bridging header auto chaining, it is possible for the compilation to have a PCH file input for the bridging header from a binary swift module dependency. In this case, we should not report a bridging header for current module as bridging header can be leaking out through swiftinterface file. To fully distinguish the PCH files passed in through different situation, here are the situations: * If no chaining is used, only `-import-objc-header` option is used and it can be used to pass either a header file or a PCH file depending if GeneratePCH job is requested or not. * If chaining is enabled, `-import-objc-header` is only used to pass the header file and `-import-pch` is used to pass PCH file. Chaining mode requires PCH generation if bridging header is used. rdar://144623388
cachemeifyoucan
force-pushed
the
eng/PR-144623388
branch
from
3af2d83 to
719edaf
Compare
cachemeifyoucan
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
ping |
artemcm
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enable bridging header auto chaining, it is possible for the compilation to have a PCH file input for the bridging header from a binary swift module dependency. In this case, we should not report a bridging header for current module as bridging header can be leaking out through swiftinterface file.
To fully distinguish the PCH files passed in through different situation, here are the situations:
-import-objc-headeroption is used and it can be used to pass either a header file or a PCH file depending if GeneratePCH job is requested or not.-import-objc-headeris only used to pass the header file and-import-pchis used to pass PCH file. Chaining mode requires PCH generation if bridging header is used.rdar://144623388