SourceKit: correct the macro definitions to avoid warnings on Windows #78821
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
ahoppen
approved these changes
Jan 22, 2025
tools/SourceKit/tools/sourcekitd/bin/InProc/CodeCompletionSwiftInterop.h
Show resolved
Hide resolved
This silences a large number of warnings due to
`-Winconsistent-dllimport`. While it is possible to support the library
to be built statically, that is not currently supported by the build
system, so simply leave that unsupported for decoration.
An option here for ELF targets would be to use
`__attribute__((__visibility__("default")))` and enable hidden
visibility by default enabling a small bit of optimization.
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences a large number of warnings due to
-Winconsistent-dllimport. While it is possible to support the library to be built statically, that is not currently supported by the build system, so simply leave that unsupported for decoration.An option here for ELF targets would be to use
__attribute__((__visibility__("default")))and enable hidden visibility by default enabling a small bit of optimization.