[cxx-interop] Fix crash trying to export read accesors #77391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
egorzhdan
reviewed
Nov 5, 2024
test/Interop/SwiftToCxx/stdlib/swift-synchronization-in-cxx.swift
Outdated
Show resolved
Hide resolved
This is not yet supported, so skip exporting those accessors for now. Fixes #77304 rdar://138944832
Xazax-hun
force-pushed
the
gaborh/avoid-exporting-read-accessors
branch
from
c3f9ccf to
e00e285
Compare
|
@swift-ci please smoke test |
egorzhdan
approved these changes
Nov 7, 2024
Xazax-hun
added a commit
that referenced
this pull request
Nov 8, 2024
Explanation: The reverse interop code assumed that there is always a synthesized get accessor for public stored properties which is not the case. This PR prevents the crash by not exporting get accessor it is not available. Scope: C++ reverse interop. Risk: Low, we just skip problematic operators. Testing: Regression test added. Issue: rdar://138944832 Reviewer: @egorzhdan Original PR: #77391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet supported, so skip exporting those accessors for now.
Fixes #77304
rdar://138944832