Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cxx-interop] Increase the size of std::strings in benchmarks #76782

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

egorzhdan
Copy link
Contributor

Since #75608, the performance of std::string <=> Swift.String conversions improved significantly. To make sure the workload is significant enough for the benchmark results to be noise-free, this bumps the size of Swift strings that are being tested.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 30, 2024
@egorzhdan
Copy link
Contributor Author

@swift-ci please benchmark

Since #75608, the performance of `std::string` <=> `Swift.String` conversions improved significantly. To make sure the workload is significant enough for the benchmark results to be noise-free, this bumps the size of Swift strings that are being tested.
@egorzhdan egorzhdan force-pushed the egorzhdan/benchmark-bump-size branch from b7642a2 to e6e5524 Compare October 1, 2024 12:24
@egorzhdan
Copy link
Contributor Author

@swift-ci please benchmark

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan requested a review from Xazax-hun October 2, 2024 12:36
@egorzhdan egorzhdan marked this pull request as ready for review October 2, 2024 12:36
@egorzhdan egorzhdan requested a review from eeckstein as a code owner October 2, 2024 12:36
@egorzhdan egorzhdan enabled auto-merge October 2, 2024 12:40
@egorzhdan egorzhdan merged commit 0005b95 into main Oct 2, 2024
4 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/benchmark-bump-size branch October 2, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants