Improve RangeSet initialization performance #75089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing a range set with a group of overlapping, identical, or empty ranges, the initializer can exhibit poor performance due to removing the unneeded ranges during processing. This change uses a partitioning scheme instead, only removing the unnecessary ranges at the end of initialization.
|
@swift-ci Please smoke test |
|
@swift-ci Please test |
jmschonfeld
reviewed
Jul 9, 2024
| let newUpper = Swift.max( | ||
| _storage[lastValid].upperBound, | ||
| _storage[current].upperBound) | ||
| _storage[lastValid] = _storage[lastValid].lowerBound ..< newUpper |
There was a problem hiding this comment.
Is it worth using Range(uncheckedBounds:) here to avoid a second bounds check since we know the if statement above has already passed? Not sure if that'll have a measurable impact, but I thought of it while reading through
There was a problem hiding this comment.
Good catch, that's what it's for!
|
@swift-ci Please test |
jmschonfeld
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a range set with a group of overlapping, identical, or empty ranges, the initializer can exhibit poor performance due to removing the unneeded ranges during processing. This change uses a partitioning scheme instead, only removing the unnecessary ranges at the end of initialization.