Add replay support for MCCAS in Swift. #74202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastogishubham
force-pushed
the
MCCASReplay
branch
3 times, most recently
from
156d06a to
f894b02
Compare
|
@swift-ci please test |
rastogishubham
requested review from
cachemeifyoucan,
akyrtzi,
adrian-prantl,
benlangmuir and
felipepiovezan
rastogishubham
force-pushed
the
MCCASReplay
branch
from
f894b02 to
b4bc1c9
Compare
|
@swift-ci please test |
rastogishubham
force-pushed
the
MCCASReplay
branch
from
b4bc1c9 to
465f588
Compare
|
@swift-ci please test |
cachemeifyoucan
requested changes
Jun 7, 2024
rastogishubham
force-pushed
the
MCCASReplay
branch
from
465f588 to
b01c2be
Compare
rastogishubham
force-pushed
the
MCCASReplay
branch
from
b01c2be to
2b9d5d4
Compare
rastogishubham
force-pushed
the
MCCASReplay
branch
from
2b9d5d4 to
eae62dc
Compare
rastogishubham
force-pushed
the
MCCASReplay
branch
from
eae62dc to
2572496
Compare
|
@swift-ci please test |
|
@cachemeifyoucan sorry for getting back on this a little late, but I think I addressed everything |
cachemeifyoucan
requested changes
Jul 8, 2024
When MCCAS is used, filter the object file from the CASOutputBackend because we do not want to write the object file in the CAS, we want to associate the MCCAS top level CAS Object to the main output of the CASOutputBackend.
This patch stores the MCCAS ObjectRef as the main output of the CASOutputBackend when MCCAS is enabled.
rastogishubham
force-pushed
the
MCCASReplay
branch
from
2572496 to
93f514e
Compare
rastogishubham
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
cachemeifyoucan
requested changes
Jul 9, 2024
rastogishubham
force-pushed
the
MCCASReplay
branch
2 times, most recently
from
e359604 to
1d4d211
Compare
|
@swift-ci please test |
This patch adds support for MCCAS when a cache hit is encountered when trying to replay a compilation, and uses the MCCAS serialization code to materialize the object file that is the main output of the compilation.
rastogishubham
force-pushed
the
MCCASReplay
branch
from
1d4d211 to
8dabf58
Compare
cachemeifyoucan
approved these changes
Jul 10, 2024
|
@swift-ci please test |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support to be able to replay a cached object file from MCCAS in the swift compiler.