Skip to content

Prepare for introducing swift-foundation into the toolchain #74019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

jmschonfeld
Copy link
Contributor

Per @parkera's update here, we will be adding swift-foundation to the toolchain and updating the swift-corelibs-foundation in the toolchain to be "re-cored" on this new implementation. This adds the initial steps to landing these changes:

  1. Update the list of checkouts to include the swift-foundation and swift-foundation icu repos
  2. Passing extra variables down to the cmake invocation of swift-corelibs-foundation so that it can appropriately find the new dependencies it will have (swift-collections, swift-syntax, swift-foundation-icu, and swift-foundation)

This change shouldn't affect the build itself today, but will allow us to introduce changes into swift-corelibs-foundation that utilize these new libraries.

@jmschonfeld
Copy link
Contributor Author

@swift-ci please smoke test

@jmschonfeld jmschonfeld merged commit 025c976 into swiftlang:main Jun 3, 2024
3 checks passed
@jmschonfeld jmschonfeld deleted the swift-foundation-toolchain branch June 3, 2024 22:15
jmschonfeld added a commit to jmschonfeld/swift that referenced this pull request Jun 3, 2024
@kateinoigakukun
Copy link
Member

Seems like we need to update CI system configurations to check out those new repositories. Some jobs on the main branch are currently failing due to missing checked outs repos. CC: @shahmishal
https://ci.swift.org/job/oss-swift-RA-linux-ubuntu-22_04/7404/console

@finagolfin
Copy link
Member

@shahmishal and @parkera, now that swift-foundation was pushed into swift-corelibs-foundation, swiftlang/swift-corelibs-foundation#5008, these two repos will need snapshot tags set up. Otherwise, a tag checkout on the 6.0/main branches will check out an arbitrary commit of swift-foundation and swift-foundation-icu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants