Fill in extended existential support for type(of:) and mirror #72943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type(of:) now returns the dynamic type of the contents of an extended existential (just like it does for a regular existential) Mirror can now reflect fields of a value stored inside an extended existential (just like it can with a regular existential). This requires type(of:) support, since Mirror internals use that to determine how to reflect a value. Resolves rdar://102906195
tbkka
commented
Apr 10, 2024
| } | ||
| } | ||
|
|
||
| mirrors.test("Extended Existential (metatype)") { |
There was a problem hiding this comment.
@slavapestov Can you think of a better way to verify the mirror support here? I have checked in a debugger that it does actually hit the expected case inside the Mirror implementation.
|
@swift-ci Please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type(of:) now returns the dynamic type of the contents of an extended existential (just like it does for a regular existential)
Mirror can now reflect fields of a value stored inside an extended existential (just like it can with a regular existential). This requires type(of:) support, since Mirror internals use that to determine how to reflect a value.
Resolves rdar://102906195