[AccessRequests] Allow Init accessor to be internal
#72857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Apr 4, 2024
li3zhen1
force-pushed
the
fix-init-accessor-71578
branch
from
5aef6c0 to
da5dd94
Compare
li3zhen1
changed the title
internal
li3zhen1
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
xedin
approved these changes
Jun 14, 2024
|
@swift-ci please test |
|
@li3zhen1 Sorry it took so long! Would you mind fixing the test-case that is failing or should I? |
|
@swift-ci please test |
slavapestov
reviewed
Jun 18, 2024
| // These are only called from designated initializers. | ||
| return AccessLevel::Private; | ||
| // These are only called from within the same module. | ||
| return std::min(storage->getFormalAccess(), AccessLevel::Internal); |
There was a problem hiding this comment.
The init accessor should be accessible within the module but it's currently impossible to use it across different files in the module.
slavapestov
reviewed
Jun 18, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal.Resolves #71578