[overlay] Make an overlay for the clang _Builtin_float module #71474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, we need some way to figure out if _Builtin_Float actually declares anything... |
ian-twilightcoder
force-pushed
the
builtin-float-overlay
branch
from
5d8a9e5 to
4638346
Compare
No wait, this is a problem with the test. |
|
Hmm, does this one make sense to anyone? |
ian-twilightcoder
force-pushed
the
builtin-float-overlay
branch
from
4638346 to
c42302b
Compare
Ah, the different overlays did different things with Float80, they just need to be conditionalized by os. |
ian-twilightcoder
force-pushed
the
builtin-float-overlay
branch
4 times, most recently
from
9ab4a14 to
083d34d
Compare
Clang's builtin float.h is no longer included in OS/SDK modules, and so it needs its own overlay. rdar://122351557
ian-twilightcoder
force-pushed
the
builtin-float-overlay
branch
from
083d34d to
1ce3935
Compare
|
@swift-ci smoke test |
|
@swift-ci test |
edymtt
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang's builtin float.h is no longer included in OS/SDK modules, and so it needs its own overlay.
rdar://122351557