[Macros] Expression macro as caller-side default argument #70602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApolloZhu
force-pushed
the
macro/expression-as-default-argument
branch
from
21938c9 to
b2baf7c
Compare
ApolloZhu
requested review from
DougGregor,
hborla,
ahoppen and
CodaFi
and removed request for
CodaFi
|
@swift-ci please smoke test |
ApolloZhu
requested review from
bnbarham,
hamishknight,
rintaro,
ktoso,
slavapestov,
xedin,
CodaFi and
tshortli
as code owners
ApolloZhu
changed the title
ApolloZhu
removed request for
bnbarham,
hamishknight,
rintaro,
ktoso,
slavapestov,
xedin,
CodaFi and
tshortli
|
@swift-ci please smoke test |
ApolloZhu
force-pushed
the
macro/expression-as-default-argument
branch
from
248e821 to
594d56b
Compare
|
@swift-ci please smoke test |
DougGregor
reviewed
Jan 29, 2024
There was a problem hiding this comment.
This is looking very good. There are a few tests we still need:
- One that serializes a public function using a default argument that's a macro expansion, then calls it from another module
- One that prints an API with a public function containing such a default argument into a .swiftinterface fiel
- One that checks the access control restrictions on the macros that can be used from a default argument
|
swiftlang/swift-syntax#2447 |
|
This will also make |
|
@swift-ci please build toolchain |
|
swiftlang/swift-syntax#2447 |
Test shadowed variable of same type Fully type check caller side macro expansion Skip macro default arg caller side expr at decl primary Test macro expand more complex expressions Set synthesized expression as implicit Add test case for with argument, not compiling currently Test with swiftinterface Always use the string representation of the default argument Now works across module boundary Check works for multiple files Make default argument expression work in single file Use expected-error Disallow expression macro as default argument Using as a sub expression in default argument still allowed as expression macros behave the same as built-in magic literals
Need to use variable from caller side context
ApolloZhu
force-pushed
the
macro/expression-as-default-argument
branch
from
44aed25 to
8da4b1e
Compare
|
swiftlang/swift-syntax#2447 |
|
swiftlang/swift-syntax#2447 |
DougGregor
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for [Pitch] Expression macro as caller-side default argument
Corresponding Swift Syntax PR: swiftlang/swift-syntax#2447
Resolves rdar://112031348