[TypeChecker] TypeChecker::isSubtypeOf should recognize Sendable s…
#70502
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ktoso,
kavon,
hborla and
slavapestov
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
force-pushed
the
subtype-between-sendable-and-non-sendable
branch
from
f4d724b to
6b60f15
Compare
xedin
changed the title
TypeChecker::isSubtypeOf should recognize @Sendable s…TypeChecker::isSubtypeOf should recognize Sendable s…
|
Generalized this to Sendable interactions in type context. |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
…ubtyping A sendable function can be a subtype of a non-@sendable function, that is currently established via a fix. `TypeChecker::isSubtypeOf` should recognize its presence and fail.
…btyping A sendable type can be a subtype of a non-Sendable type, i.e. `any X & Sendable` vs. `X` where `X` is a class. The solver adjusts `MissingSynthesizableConformance` to indicate that one of the types is missing `Sendable` and that needs to be recognized by `TypeChecker::isSubtypeOf`.
xedin
force-pushed
the
subtype-between-sendable-and-non-sendable
branch
from
6b60f15 to
359ea14
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Source compat failure is due to |
|
Please test with following pull request: @swift-ci Please test source compatibility |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Mar 8, 2024
|
@swift-ci please smoke test |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Apr 5, 2024
This approach regressed existing ternary expressions that join to `any Sendable` and one brach is inferred from the ternary type variable.
xedin
added a commit
to xedin/swift
that referenced
this pull request
Apr 5, 2024
This approach regressed existing ternary expressions that join to `any Sendable` and one branch is inferred from the ternary type variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ubtyping
A sendable type can be a subtype of a non-Sendable type.
That is currently established via a fix (for function types) and score change
(
SK_MissingSynthesizableConformancefor regular nominal types).TypeChecker::isSubtypeOfshould recognize its presence and fail.