Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AST: Remodel MemberTypeRepr to be recursive #70467

Merged
merged 16 commits into from
Feb 16, 2024
Merged

AST: Remodel MemberTypeRepr to be recursive #70467

merged 16 commits into from
Feb 16, 2024

Conversation

AnthonyLatsis
Copy link
Collaborator

A public interface that forces clients to interpret and traverse MemberTypeRepr nodes recursively such that every qualified type identifier is a MemberTypeRepr pointing to its qualifier:

  • Is a more natural and bug-proof solution because each subsequent dot-separated identifier is not self-standing as in a tuple element. In the previous model, all type identifiers are standalone IdentTypeRepr nodes, and the only way to tell whether one is qualified is to look at the parent node, which is normally not a straightforward task with our AST. Knowledge of whether a type identifier is qualified is important in many of our analyses, but the absence of a general typed or other visible distinction between qualified and unqualified type identifiers is not helpful in guiding contributors to this realization.
  • Grants more out-of-the-box flexibility to ASTWalker clients. IdentTypeRepr nodes are now unqualified by definition, and since each next dot-separated components is now itself a MemberTypeRepr and a parent of the previous one (vs. all components being direct descendants of a single MemberTypeRepr), children may be skipped halfway through a MemberTypeRepr.
  • Will simplify modeling .Type and .Protocol types as MemberTypeRepr.

@AnthonyLatsis AnthonyLatsis mentioned this pull request Dec 14, 2023
Open
@slavapestov
Copy link
Contributor

Excellent!

@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from 24ae79c to f326a7d Compare December 15, 2023 12:55
@AnthonyLatsis

This comment was marked as duplicate.

Sign in to view
@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from f326a7d to 92c238b Compare December 15, 2023 13:19
@AnthonyLatsis

This comment was marked as duplicate.

Sign in to view
@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from 92c238b to 9cc9fd3 Compare December 15, 2023 20:23
@AnthonyLatsis

This comment was marked as duplicate.

Sign in to view
@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from 9cc9fd3 to 01ba7c6 Compare December 16, 2023 01:44
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test source compatibility release

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test compiler performance

hamishknight
hamishknight approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

include/swift/AST/TypeRepr.h
@@ -363,55 +373,20 @@ class DeclRefTypeRepr : public TypeRepr {
/// Bar<Gen>
/// \endcode
class IdentTypeRepr : public DeclRefTypeRepr {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, would it be worth folding IdentTypeRepr + SimpleIdentTypeRepr + GenericIdentTypeRepr together into a single type at this point? Are there many clients relying on the distinction here?

Merging them would provide consistency with MemberTypeRepr where generic args don't have their own TypeRepr, and would help avoid clients attempting to handle GenericIdentTypeRepr and assuming that's sufficient to handle all generic args present in the TypeRepr, instead of using the API on DeclRefTypeRepr. As a bonus, it would also more closely match SwiftSyntax's IdentifierTypeSyntax.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s the plan! With this PR, there are around 9 TypeKind checks and dynamic casts benefitting from the type-level distinction; no API-level clients apart from visitors. I’m not entirely happy about having to call hasGenericArgList on top of isa, but merging SimpleIdentTypeRepr and GenericIdentTypeRepr also makes isa faster for IdentTypeRepr and DeclRefTypeRepr, and it feels like it will balance out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#70608.

@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from 01ba7c6 to 90754bc Compare December 20, 2023 01:45
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test compiler performance

@AnthonyLatsis
Copy link
Collaborator Author

Summary for main full

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 144,966,420,101,645 145,119,598,291,718 153,178,190,073 0.11%
LLVM.NumLLVMBytesOutput 2,655,829,332 2,655,894,712 65,380 0.0%

debug-batch detailed

Regressed (1)
name old new delta delta_pct
AST.NumPrecedenceGroups 140 141 1 1.07% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (341)
name old new delta delta_pct
AST.ImportSetCacheHit 4,392,980 4,393,274 294 0.01%
AST.ImportSetCacheMiss 804,563 804,630 67 0.01%
AST.ImportSetFoldHit 405,177 405,232 55 0.01%
AST.ImportSetFoldMiss 399,386 399,398 12 0.0%
AST.ModuleShadowCacheHit 72,887 73,299 412 0.57%
AST.ModuleShadowCacheMiss 5,359 5,377 18 0.34%
AST.ModuleVisibilityCacheHit 93,136,473 93,153,183 16,710 0.02%
AST.ModuleVisibilityCacheMiss 410,381 410,442 61 0.01%
AST.NumASTBytesAllocated 65,989,585,250 66,112,063,336 122,478,085 0.19%
AST.NumASTScopeExpansions 9,610,904 9,611,733 829 0.01%
AST.NumASTScopeLookups 10,533,861 10,535,264 1,402 0.01%
AST.NumDecls 357,853 357,971 118 0.03%
AST.NumDependencies 269,394 269,386 -8 -0.0%
AST.NumIncrementalDependencies 28,792 28,792 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 322,193 322,191 -2 -0.0%
AST.NumLocalTypeDecls 6,812 6,812 0 0.0%
AST.NumModuleLookupClassMember 6,409 6,409 0 0.0%
AST.NumModuleLookupValue 118,493,568 118,503,963 10,394 0.01%
AST.NumObjCMethods 95,288 95,299 11 0.01%
AST.NumOperators 885 890 5 0.62%
AST.NumReferencedDynamicNames 148 148 0 0.0%
AST.NumReferencedMemberNames 15,779,877 15,779,972 95 0.0%
AST.NumReferencedTopLevelNames 1,402,981 1,402,944 -37 -0.0%
AST.NumSourceBuffers 408,394 408,389 -5 -0.0%
AST.NumSourceLines 13,476,934 13,482,124 5,190 0.04%
AST.NumSourceLinesPerSecond 5,086,838 5,058,338 -28,500 -0.56%
AST.NumTotalClangImportedEntities 1,798,546 1,796,856 -1,690 -0.09%
Frontend.MaxMallocUsage 931,142,638,104 931,541,544,648 398,906,544 0.04%
Frontend.NumInstructionsExecuted 144,966,420,101,645 145,119,598,291,718 153,178,190,073 0.11%
Frontend.NumProcessFailures 40 40 0 0.0%
IRGen.IRGenRequest 29,613 29,613 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 331,400 331,400 0 0.0%
IRModule.NumIRAliases 268,504 268,504 0 0.0%
IRModule.NumIRBasicBlocks 8,901,743 8,901,743 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 4,855,427 4,855,427 0 0.0%
IRModule.NumIRGlobals 4,549,292 4,549,292 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 94,129,297 94,129,297 0 0.0%
IRModule.NumIRNamedMetaData 119,972 119,972 0 0.0%
IRModule.NumIRValueSymbols 9,494,900 9,494,900 0 0.0%
LLVM.NumLLVMBytesOutput 2,655,829,332 2,655,894,712 65,380 0.0%
Parse.ExportedSourceFileRequest 4 4 0 0.0%
Parse.IDEInspectionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 680,189 680,023 -166 -0.02%
Parse.NumIterableDeclContextParsed 871,578 871,685 106 0.01%
Parse.ParseAbstractFunctionBodyRequest 784,397 784,560 163 0.02%
Parse.ParseMembersRequest 675,238 675,405 167 0.02%
Parse.ParseSourceFileRequest 374,442 374,441 -1 -0.0%
Parse.ParseTopLevelDeclsRequest 374,442 374,441 -1 -0.0%
SILGen.ASTLoweringRequest 30,829 30,829 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 3,804,529 3,804,529 0 0.0%
SILModule.NumSILGenGlobalVariables 132,960 132,960 0 0.0%
SILModule.NumSILGenVtables 40,679 40,679 0 0.0%
SILModule.NumSILGenWitnessTables 235,765 235,765 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 4,244,748 4,244,748 0 0.0%
SILModule.NumSILOptGlobalVariables 135,031 135,031 0 0.0%
SILModule.NumSILOptVtables 41,266 41,266 0 0.0%
SILModule.NumSILOptWitnessTables 274,277 274,277 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 151,741 151,741 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 330,742 330,762 20 0.01%
Sema.AbstractGenericSignatureRequest 118,707 118,711 4 0.0%
Sema.AccessLevelRequest 21,105,075 21,272,595 167,519 0.79%
Sema.ActorIsolationRequest 45,236,460 45,548,741 312,280 0.69%
Sema.AllMembersRequest 186,397 186,397 0 0.0%
Sema.AnyObjectLookupRequest 217 217 0 0.0%
Sema.ApplyAccessNoteRequest 4,814,021 4,816,333 2,312 0.05%
Sema.AreAllStoredPropertiesDefaultInitableRequest 51,822 51,828 6 0.01%
Sema.AssociatedConformanceRequest 187,070 187,090 19 0.01%
Sema.AttachedPropertyWrapperTypeRequest 35,322 35,337 15 0.04%
Sema.AttachedPropertyWrappersRequest 31,302,449 31,470,891 168,441 0.54%
Sema.AttachedResultBuilderRequest 2,074,295 2,074,773 478 0.02%
Sema.BodyInitKindRequest 85,638 85,641 2 0.0%
Sema.BreakTargetRequest 7,370 7,375 4 0.06%
Sema.CXXNamespaceMemberLookup 0 0 0 0.0%
Sema.CallerSideDefaultArgExprRequest 509,949 509,949 0 0.0%
Sema.CheckDistributedFunctionRequest 80 80 0 0.0%
Sema.CheckInconsistentAccessLevelOnImport 59,797 59,821 24 0.04%
Sema.CheckInconsistentImplementationOnlyImportsRequest 10,635 10,635 0 0.0%
Sema.CheckInconsistentSPIOnlyImportsRequest 59,797 59,821 24 0.04%
Sema.CheckInconsistentWeakLinkedImportsRequest 10,635 10,635 0 0.0%
Sema.CheckRedeclarationRequest 2,577,764 2,578,551 786 0.03%
Sema.ClangCategoryLookupRequest 0 0 0 0.0%
Sema.ClangDirectLookupRequest 17,757 17,740 -17 -0.1%
Sema.ClangRecordMemberLookup 17,757 17,740 -17 -0.1%
Sema.ClassAncestryFlagsRequest 153,873 153,954 81 0.05%
Sema.ClosureEffectsRequest 160,446 160,423 -23 -0.01%
Sema.ClosureHasExplicitResultRequest 61,256 61,243 -13 -0.02%
Sema.CollectOverriddenDeclsRequest 16,878,968 16,975,614 96,646 0.57%
Sema.CompareDeclSpecializationRequest 917,230 918,229 999 0.11%
Sema.CompilerPluginLoadRequest 4 4 0 0.0%
Sema.ConditionalRequirementsRequest 955,793 957,233 1,440 0.15%
Sema.ConformanceHasEffectRequest 81 81 0 0.0%
Sema.ConstantValueInfoRequest 0 0 0 0.0%
Sema.ContinueTargetRequest 2,467 2,467 0 -0.02%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 27,604 27,646 42 0.15%
Sema.CustomAttrTypeRequest 4,533 4,534 1 0.02%
Sema.CustomRefCountingOperation 0 0 0 0.0%
Sema.CxxRecordAsSwiftType 0 0 0 0.0%
Sema.CxxRecordSemantics 64,615 64,630 14 0.02%
Sema.DefaultAndMaxAccessLevelRequest 129,118 129,126 8 0.01%
Sema.DefaultArgumentExprRequest 140,183 140,260 77 0.05%
Sema.DefaultArgumentInitContextRequest 935 935 0 0.0%
Sema.DefaultArgumentTypeRequest 17,541 17,542 1 0.01%
Sema.DefaultDefinitionTypeRequest 2,189 2,188 -1 -0.07%
Sema.DefaultInitializerIsolation 1,399,226 1,399,727 500 0.04%
Sema.DefaultTypeRequest 719,700 719,733 32 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 92,000,626 92,051,950 51,324 0.06%
Sema.DirectOperatorLookupRequest 2,513,002 2,513,170 168 0.01%
Sema.DirectPrecedenceGroupLookupRequest 934,788 934,932 144 0.02%
Sema.DistributedModuleIsAvailableRequest 67 67 0 0.0%
Sema.DynamicallyReplacedDeclRequest 42,237,360 42,533,042 295,682 0.7%
Sema.EnumElementExprPatternRequest 23 23 0 0.0%
Sema.EnumRawTypeRequest 44,942 44,956 14 0.03%
Sema.EnumRawValuesRequest 26,478 26,494 16 0.06%
Sema.ExistentialConformsToSelfRequest 34,910 34,931 20 0.06%
Sema.ExpandAccessorMacros 1,142,968 1,143,116 147 0.01%
Sema.ExpandBodyMacroRequest 480,767 480,667 -100 -0.02%
Sema.ExpandChildTypeRefinementContextsRequest 794,793 794,956 163 0.02%
Sema.ExpandExtensionMacros 1,128,577 1,132,091 3,514 0.31%
Sema.ExpandMacroExpansionDeclRequest 0 0 0 0.0%
Sema.ExpandMacroExpansionExprRequest 0 0 0 0.0%
Sema.ExpandMemberAttributeMacros 75,293,521 75,645,296 351,774 0.47%
Sema.ExpandPeerMacroRequest 54,543,606 54,892,289 348,683 0.64%
Sema.ExpandPreambleMacroRequest 480,767 480,667 -100 -0.02%
Sema.ExpandSynthesizedMemberMacroRequest 335,420 335,452 31 0.01%
Sema.ExplicitCaughtTypeRequest 36,766 36,736 -30 -0.08%
Sema.ExprPatternMatchRequest 95,820 95,820 0 0.0%
Sema.ExtendedNominalRequest 760,160 760,166 6 0.0%
Sema.ExtendedTypeRequest 242,276 242,310 34 0.01%
Sema.ExternalMacroDefinitionRequest 4 4 0 0.0%
Sema.FragileFunctionKindRequest 3,202,409 3,203,112 703 0.02%
Sema.FunctionOperatorRequest 20,269 20,279 10 0.05%
Sema.GenericParamListRequest 7,737,392 7,746,996 9,604 0.12%
Sema.GenericSignatureRequest 3,829,782 3,831,807 2,025 0.05%
Sema.GetDestructorRequest 47,484 47,492 7 0.02%
Sema.GetDistributedActorArgumentDecodingMethodRequest 19 19 0 0.0%
Sema.GetDistributedActorIDPropertyRequest 72 72 0 0.0%
Sema.GetDistributedActorImplicitCodableRequest 117 117 0 0.0%
Sema.GetDistributedActorInvocationDecoderRequest 19 19 0 0.0%
Sema.GetDistributedActorSystemPropertyRequest 63 63 0 0.0%
Sema.GetDistributedActorSystemRemoteCallFunctionRequest 40 40 0 0.0%
Sema.GetDistributedRemoteCallArgumentInitFunctionRequest 14 14 0 0.0%
Sema.GetDistributedRemoteCallTargetInitFunctionRequest 14 14 0 0.0%
Sema.GetDistributedTargetInvocationDecoderDecodeNextArgumentFunctionRequest 21 21 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordArgumentFunctionRequest 16 16 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordErrorTypeFunctionRequest 8 8 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordReturnTypeFunctionRequest 13 13 0 0.0%
Sema.GetDistributedTargetInvocationResultHandlerOnReturnFunctionRequest 12 12 0 0.0%
Sema.GetDistributedThunkRequest 80 80 0 0.0%
Sema.GetSourceFileAsyncNode 142 142 0 0.0%
Sema.GlobalActorAttributeRequest 49,140,166 49,472,510 332,344 0.68%
Sema.GlobalActorInstanceRequest 2,565 2,582 16 0.64%
Sema.HasCircularInheritedProtocolsRequest 19,176 19,164 -12 -0.07%
Sema.HasCircularRawValueRequest 27,465 27,483 17 0.06%
Sema.HasDefaultInitRequest 117,660 117,698 37 0.03%
Sema.HasDynamicCallableAttributeRequest 32,996 32,927 -69 -0.21%
Sema.HasDynamicMemberLookupAttributeRequest 603,938 604,516 577 0.1%
Sema.HasImportsMatchingFlagRequest 740,821 740,818 -3 -0.0%
Sema.HasInitAccessorRequest 6,065,124 6,081,683 16,559 0.27%
Sema.HasIsolatedSelfRequest 54,781,695 55,135,785 354,090 0.65%
Sema.HasMemberwiseInitRequest 62,689 62,714 24 0.04%
Sema.HasMissingDesignatedInitializersRequest 33,411 33,413 2 0.01%
Sema.HasSelfOrAssociatedTypeRequirementsRequest 17,046 17,054 8 0.05%
Sema.HasStorageRequest 17,550,960 17,700,292 149,331 0.85%
Sema.HasUserDefinedDesignatedInitRequest 117,670 117,708 37 0.03%
Sema.IDEInspectionFileRequest 0 0 0 0.0%
Sema.ImplementsAttrProtocolRequest 0 0 0 0.0%
Sema.ImplicitKnownProtocolConformanceRequest 278,430 279,008 578 0.21%
Sema.InferredGenericSignatureRequest 255,927 255,905 -21 -0.01%
Sema.InheritedDeclsReferencedRequest 8,272,825 8,281,926 9,101 0.11%
Sema.InheritedProtocolsRequest 873,432 874,759 1,327 0.15%
Sema.InheritedTypeRequest 510,460 510,329 -130 -0.03%
Sema.InheritsSuperclassInitializersRequest 42,293 42,301 8 0.02%
Sema.InitAccessorPropertiesRequest 82,127 82,133 6 0.01%
Sema.InitAccessorReferencedVariablesRequest 0 0 0 0.0%
Sema.InitKindRequest 225,036 225,080 44 0.02%
Sema.InterfaceTypeRequest 26,282,825 26,383,551 100,726 0.38%
Sema.InvertibleAnnotationRequest 1,135,193 1,135,114 -79 -0.01%
Sema.IsABICompatibleOverrideRequest 385,929 385,929 0 0.0%
Sema.IsAccessorTransparentRequest 672,866 673,054 187 0.03%
Sema.IsActorRequest 2,697,348 2,703,667 6,318 0.23%
Sema.IsCCompatibleFuncDeclRequest 0 0 0 0.0%
Sema.IsCallAsFunctionNominalRequest 7,282 7,277 -5 -0.07%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 73,017 72,984 -32 -0.04%
Sema.IsDefaultActorRequest 52,894 52,894 0 0.0%
Sema.IsDistributedActorRequest 2,905,373 2,911,857 6,484 0.22%
Sema.IsDynamicRequest 40,955,860 41,268,182 312,322 0.76%
Sema.IsEscapableRequest 0 0 0 0.0%
Sema.IsFinalRequest 40,880,322 41,191,699 311,377 0.76%
Sema.IsFunctionBodySkippedRequest 2,075,547 2,076,135 587 0.03%
Sema.IsGetterMutatingRequest 916,220 916,430 210 0.02%
Sema.IsImplicitlyUnwrappedOptionalRequest 4,422,264 4,421,962 -302 -0.01%
Sema.IsNonUserModuleRequest 106,779 106,797 18 0.02%
Sema.IsNoncopyableRequest 0 0 0 0.0%
Sema.IsObjCRequest 3,389,024 3,391,049 2,025 0.06%
Sema.IsSafeUseOfCxxDecl 0 0 0 0.0%
Sema.IsSetterMutatingRequest 822,108 822,271 163 0.02%
Sema.IsSingleValueStmtRequest 407,240 407,184 -55 -0.01%
Sema.IsStaticRequest 1,841,102 1,841,513 411 0.02%
Sema.LazyStoragePropertyRequest 2,597 2,597 0 0.0%
Sema.LocalDiscriminatorsRequest 633,898 633,898 0 0.0%
Sema.LookupAllConformancesInContextRequest 3,501,980 3,525,411 23,431 0.67%
Sema.LookupConformanceInModuleRequest 74,553,501 74,799,573 246,072 0.33%
Sema.LookupInModuleRequest 10,544,777 10,544,678 -99 -0.0%
Sema.LookupInfixOperatorRequest 84,411 84,409 -2 -0.0%
Sema.LookupPostfixOperatorRequest 74 74 0 0.0%
Sema.LookupPrecedenceGroupRequest 34,234 34,240 6 0.02%
Sema.LookupPrefixOperatorRequest 372 374 2 0.54%
Sema.MacroDefinitionRequest 8 8 0 0.0%
Sema.MangleLocalTypeDeclRequest 3,208 3,208 0 0.0%
Sema.MemberwiseInitPropertiesRequest 82,129 82,135 6 0.01%
Sema.ModuleImplicitImportsRequest 10,635 10,635 0 0.0%
Sema.ModuleLibraryLevelRequest 22 22 0 0.0%
Sema.ModuleQualifiedLookupRequest 3,911,882 3,909,864 -2,018 -0.05%
Sema.NamedLazyMemberLoadSuccessCount 67,660,879 67,743,174 82,295 0.12%
Sema.NamingPatternRequest 270,584 270,639 54 0.02%
Sema.NeedsNewVTableEntryRequest 1,237,889 1,237,889 0 0.0%
Sema.NumAccessorBodiesSynthesized 380,227 380,396 168 0.04%
Sema.NumAccessorsSynthesized 616,949 617,273 324 0.05%
Sema.NumConformancePathsRecorded 968,195 968,823 628 0.06%
Sema.NumConformancesDeserialized 6,540,360 6,555,985 15,624 0.24%
Sema.NumConstraintScopes 85,671,364 85,679,128 7,764 0.01%
Sema.NumConstraintsConsideredForEdgeContraction 2,878,343 2,878,311 -32 -0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 103,752,954 104,191,121 438,166 0.42%
Sema.NumDeclsTypechecked 3,645,130 3,646,266 1,135 0.03%
Sema.NumLazyIterableDeclContexts 15,199,497 15,236,904 37,407 0.25%
Sema.NumLazyRequirementSignatures 1,156,617 1,158,194 1,577 0.14%
Sema.NumLazyRequirementSignaturesLoaded 809,515 811,003 1,488 0.18%
Sema.NumLeafScopes 67,107,361 67,114,681 7,320 0.01%
Sema.NumRequirementMachineCompletionSteps 27,793,844 27,883,961 90,117 0.32%
Sema.NumRequirementMachineUnifiedConcreteTerms 1,425,362 1,432,185 6,823 0.48%
Sema.NumRequirementMachines 2,408,277 2,415,332 7,055 0.29%
Sema.NumTypesDeserialized 27,481,674 27,569,058 87,384 0.32%
Sema.NumUnloadedLazyIterableDeclContexts 11,391,699 11,400,312 8,613 0.08%
Sema.ObjCInterfaceAndImplementationRequest 2,594,834 2,595,371 537 0.02%
Sema.OpaqueReadOwnershipRequest 560,867 561,090 223 0.04%
Sema.OpaqueResultTypeRequest 961 962 1 0.16%
Sema.OperatorPrecedenceGroupRequest 943 946 3 0.37%
Sema.OverriddenDeclsRequest 25,658,244 25,838,278 180,033 0.7%
Sema.ParamSpecifierRequest 2,364,696 2,364,942 246 0.01%
Sema.PatternBindingCheckedAndContextualizedInitRequest 447,341 447,386 45 0.01%
Sema.PatternBindingEntryRequest 900,704 900,884 180 0.02%
Sema.PatternTypeRequest 1,071,556 1,071,723 166 0.02%
Sema.PolymorphicEffectKindRequest 1,180,068 1,179,888 -180 -0.02%
Sema.PolymorphicEffectRequirementsRequest 92 92 0 0.0%
Sema.PotentialMacroExpansionsInContextRequest 7,650,577 7,656,188 5,611 0.07%
Sema.PreCheckFunctionBodyRequest 474,808 474,733 -75 -0.02%
Sema.PreCheckResultBuilderRequest 1,502 1,502 0 0.0%
Sema.PreCheckReturnStmtRequest 649,677 649,583 -93 -0.01%
Sema.PrimaryAssociatedTypesRequest 21,277 21,465 188 0.88%
Sema.PrimarySourceFilesRequest 10,635 10,635 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 3,116,854 3,117,018 163 0.01%
Sema.PropertyWrapperBackingPropertyTypeRequest 35,322 35,337 15 0.04%
Sema.PropertyWrapperInitializerInfoRequest 795,783 795,946 163 0.02%
Sema.PropertyWrapperLValuenessRequest 2,718 2,718 0 0.0%
Sema.PropertyWrapperMutabilityRequest 909,010 909,218 208 0.02%
Sema.PropertyWrapperTypeInfoRequest 713 714 1 0.14%
Sema.ProtocolDependenciesRequest 695,107 696,146 1,039 0.15%
Sema.ProtocolRequirementsRequest 84,907 84,919 12 0.01%
Sema.ProtocolRequiresClassRequest 50,261 50,136 -125 -0.25%
Sema.ProvideDefaultImplForRequest 16,878,968 16,975,614 96,646 0.57%
Sema.QualifiedLookupRequest 11,271,313 11,283,311 11,998 0.11%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RawCommentRequest 1,381,391 1,381,391 0 0.0%
Sema.RenamedDeclRequest 5,956 5,956 0 0.0%
Sema.RequirementRequest 198,273 198,282 9 0.0%
Sema.RequirementSignatureRequest 870,368 871,746 1,377 0.16%
Sema.RequiresOpaqueAccessorsRequest 2,321,042 2,321,062 20 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 561,196 561,398 202 0.04%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 1,142,908 1,144,247 1,338 0.12%
Sema.ResolveMacroConformances 8 8 0 0.0%
Sema.ResolveMacroRequest 31,714 31,755 41 0.13%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveRawLayoutLikeTypeRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 6,265,397 6,265,796 398 0.01%
Sema.ResultBuilderTypeRequest 609,091 609,019 -71 -0.01%
Sema.ResultTypeRequest 1,382,352 1,382,706 353 0.03%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 9,237,598 9,257,303 19,705 0.21%
Sema.ScopedImportLookupRequest 928 928 0 0.0%
Sema.SelfAccessKindRequest 1,179,366 1,179,447 81 0.01%
Sema.SelfBoundsFromGenericSignatureRequest 112,491 112,496 5 0.0%
Sema.SelfBoundsFromWhereClauseRequest 2,097,819 2,096,036 -1,783 -0.09%
Sema.SemanticAvailableRangeAttrRequest 11,651 11,664 13 0.11%
Sema.SemanticBriefCommentRequest 208,700 208,700 0 0.0%
Sema.SemanticDeclAttrsRequest 40,754,401 41,090,394 335,993 0.82%
Sema.SemanticUnavailableAttrRequest 3,192,932 3,192,936 3 0.0%
Sema.SerializeAttrGenericSignatureRequest 960 960 0 0.0%
Sema.SetterAccessLevelRequest 314,094 314,156 62 0.02%
Sema.SimpleDidSetRequest 4,138,781 4,150,305 11,524 0.28%
Sema.SpecializeAttrTargetDeclRequest 3,175 3,175 0 0.0%
Sema.StorageImplInfoRequest 2,293,466 2,293,484 17 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 75,779 75,779 0 0.0%
Sema.StoredPropertiesRequest 458,132 458,157 24 0.01%
Sema.StructuralRequirementsRequest 61,057 60,946 -111 -0.18%
Sema.StructuralTypeRequest 2,107 2,110 3 0.17%
Sema.SuperclassDeclRequest 595,369 596,119 749 0.13%
Sema.SuperclassTypeRequest 78,717 78,726 8 0.01%
Sema.SynthesizeAccessorRequest 616,949 617,273 324 0.05%
Sema.SynthesizeDefaultInitRequest 14,502 14,499 -3 -0.02%
Sema.SynthesizeMainFunctionRequest 286,985 286,994 9 0.0%
Sema.SynthesizeMemberwiseInitRequest 12,912 12,917 5 0.04%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeAliasRequirementsRequest 61,057 60,946 -111 -0.18%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 904,600 904,661 61 0.01%
Sema.TypeCheckObjCImplementationRequest 0 0 0 0.0%
Sema.TypeCheckSourceFileRequest 59,797 59,821 24 0.04%
Sema.TypeDeclsFromWhereClauseRequest 61,747 61,743 -4 -0.01%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 20,740 20,743 2 0.01%
Sema.USRGenerationRequest 18,823,819 18,922,462 98,642 0.52%
Sema.UnderlyingTypeDeclsReferencedRequest 550,207 550,647 439 0.08%
Sema.UnderlyingTypeRequest 63,974 63,992 18 0.03%
Sema.UniqueUnderlyingTypeSubstitutionsRequest 1,601 1,601 0 0.0%
Sema.UnqualifiedLookupRequest 7,920,867 7,922,733 1,865 0.02%
Sema.ValidatePrecedenceGroupRequest 294,881 294,935 54 0.02%
Sema.ValueWitnessRequest 88,884 88,898 14 0.02%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 29,627 29,627 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 97,238,852,924,726 97,226,909,589,082 -11,943,335,644 -0.01%
LLVM.NumLLVMBytesOutput 2,378,594,264 2,378,632,964 38,700 0.0%

release detailed

Regressed (1)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 352,257 364,051 11,794 3.35% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (341)
name old new delta delta_pct
AST.ImportSetCacheHit 1,947,953 1,947,953 0 0.0%
AST.ImportSetCacheMiss 87,638 87,638 0 0.0%
AST.ImportSetFoldHit 46,508 46,508 0 0.0%
AST.ImportSetFoldMiss 41,130 41,130 0 0.0%
AST.ModuleShadowCacheHit 6,988 6,988 0 0.0%
AST.ModuleShadowCacheMiss 1,649 1,649 0 0.0%
AST.ModuleVisibilityCacheHit 42,884,197 42,884,197 0 0.0%
AST.ModuleVisibilityCacheMiss 64,673 64,673 0 0.0%
AST.NumASTBytesAllocated 12,558,986,603 12,556,580,383 -2,406,220 -0.02%
AST.NumASTScopeExpansions 4,248,161 4,248,161 0 0.0%
AST.NumASTScopeLookups 5,802,519 5,802,535 16 0.0%
AST.NumDecls 191,860 191,860 0 0.0%
AST.NumDependencies 27,599 27,599 0 0.0%
AST.NumIncrementalDependencies 58 58 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 32,058 32,058 0 0.0%
AST.NumLocalTypeDecls 362 362 0 0.0%
AST.NumModuleLookupClassMember 6,680 6,680 0 0.0%
AST.NumModuleLookupValue 42,744,454 42,744,454 0 0.0%
AST.NumObjCMethods 19,546 19,546 0 0.0%
AST.NumOperators 503 503 0 0.0%
AST.NumPrecedenceGroups 87 87 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 4,426 4,426 0 0.0%
AST.NumReferencedTopLevelNames 352 352 0 0.0%
AST.NumSourceBuffers 41,438 41,438 0 0.0%
AST.NumSourceLines 6,910,755 6,910,755 0 0.0%
AST.NumTotalClangImportedEntities 456,956 456,956 0 0.0%
Frontend.MaxMallocUsage 281,347,448,808 280,998,916,232 -348,532,576 -0.12%
Frontend.NumInstructionsExecuted 97,238,852,924,726 97,226,909,589,082 -11,943,335,644 -0.01%
Frontend.NumProcessFailures 11 11 0 0.0%
IRGen.IRGenRequest 12 12 0 0.0%
IRGen.OptimizedIRRequest 0 0 0 0.0%
IRGen.SymbolObjectCodeRequest 0 0 0 0.0%
IRModule.NumGOTEntries 292,882 292,882 0 0.0%
IRModule.NumIRAliases 180,067 180,067 0 0.0%
IRModule.NumIRBasicBlocks 6,381,177 6,381,177 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,319,583 3,319,583 0 0.0%
IRModule.NumIRGlobals 3,651,025 3,651,025 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 50,634,995 50,634,995 0 0.0%
IRModule.NumIRNamedMetaData 115,912 115,912 0 0.0%
IRModule.NumIRValueSymbols 6,992,107 6,992,107 0 0.0%
LLVM.NumLLVMBytesOutput 2,378,594,264 2,378,632,964 38,700 0.0%
Parse.ExportedSourceFileRequest 2 2 0 0.0%
Parse.IDEInspectionSecondPassRequest 0 0 0 0.0%
Parse.NumFunctionsParsed 422,628 422,628 0 0.0%
Parse.NumIterableDeclContextParsed 139,910 139,910 0 0.0%
Parse.ParseAbstractFunctionBodyRequest 351,023 351,023 0 0.0%
Parse.ParseMembersRequest 14,446 14,446 0 0.0%
Parse.ParseSourceFileRequest 34,304 34,304 0 0.0%
Parse.ParseTopLevelDeclsRequest 34,304 34,304 0 0.0%
SILGen.ASTLoweringRequest 1,319 1,319 0 0.0%
SILGen.ParseSILModuleRequest 0 0 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 830 830 0 0.0%
SILModule.NumSILGenFunctions 1,611,106 1,611,106 0 0.0%
SILModule.NumSILGenGlobalVariables 63,727 63,727 0 0.0%
SILModule.NumSILGenVtables 24,156 24,156 0 0.0%
SILModule.NumSILGenWitnessTables 110,751 110,751 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 830 830 0 0.0%
SILModule.NumSILOptFunctions 1,388,509 1,388,509 0 0.0%
SILModule.NumSILOptGlobalVariables 45,269 45,269 0 0.0%
SILModule.NumSILOptVtables 31,220 31,220 0 0.0%
SILModule.NumSILOptWitnessTables 111,235 111,235 0 0.0%
SILOptimizer.ExecuteSILPipelineRequest 6,491 6,491 0 0.0%
SILOptimizer.LoweredSILRequest 0 0 0 0.0%
Sema.ABIMembersRequest 147,255 147,255 0 0.0%
Sema.AbstractGenericSignatureRequest 83,509 83,509 0 0.0%
Sema.AccessLevelRequest 2,238,153 2,238,153 0 0.0%
Sema.ActorIsolationRequest 3,696,136 3,696,136 0 0.0%
Sema.AllMembersRequest 131,124 131,124 0 0.0%
Sema.AnyObjectLookupRequest 236 236 0 0.0%
Sema.ApplyAccessNoteRequest 2,411,766 2,411,766 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 21,538 21,538 0 0.0%
Sema.AssociatedConformanceRequest 75,410 75,410 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 10,600 10,600 0 0.0%
Sema.AttachedPropertyWrappersRequest 4,406,195 4,406,195 0 0.0%
Sema.AttachedResultBuilderRequest 1,180,192 1,180,192 0 0.0%
Sema.BodyInitKindRequest 66,634 66,634 0 0.0%
Sema.BreakTargetRequest 6,284 6,284 0 0.0%
Sema.CXXNamespaceMemberLookup 0 0 0 0.0%
Sema.CallerSideDefaultArgExprRequest 163,227 163,227 0 0.0%
Sema.CheckDistributedFunctionRequest 42 42 0 0.0%
Sema.CheckInconsistentAccessLevelOnImport 34,280 34,280 0 0.0%
Sema.CheckInconsistentImplementationOnlyImportsRequest 1,330 1,330 0 0.0%
Sema.CheckInconsistentSPIOnlyImportsRequest 34,280 34,280 0 0.0%
Sema.CheckInconsistentWeakLinkedImportsRequest 1,330 1,330 0 0.0%
Sema.CheckRedeclarationRequest 1,429,051 1,429,051 0 0.0%
Sema.ClangCategoryLookupRequest 0 0 0 0.0%
Sema.ClangDirectLookupRequest 12,682 12,682 0 0.0%
Sema.ClangRecordMemberLookup 12,682 12,682 0 0.0%
Sema.ClassAncestryFlagsRequest 56,516 56,516 0 0.0%
Sema.ClosureEffectsRequest 115,523 115,523 0 0.0%
Sema.ClosureHasExplicitResultRequest 39,025 39,025 0 0.0%
Sema.CollectOverriddenDeclsRequest 20,763 20,763 0 0.0%
Sema.CompareDeclSpecializationRequest 506,596 506,596 0 0.0%
Sema.CompilerPluginLoadRequest 2 2 0 0.0%
Sema.ConditionalRequirementsRequest 262,967 262,967 0 0.0%
Sema.ConformanceHasEffectRequest 61 61 0 0.0%
Sema.ConstantValueInfoRequest 0 0 0 0.0%
Sema.ContinueTargetRequest 2,196 2,196 0 0.0%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 10,025 10,025 0 0.0%
Sema.CustomAttrTypeRequest 1,289 1,289 0 0.0%
Sema.CustomRefCountingOperation 0 0 0 0.0%
Sema.CxxRecordAsSwiftType 0 0 0 0.0%
Sema.CxxRecordSemantics 16,996 16,996 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 62,223 62,223 0 0.0%
Sema.DefaultArgumentExprRequest 70,706 70,706 0 0.0%
Sema.DefaultArgumentInitContextRequest 173 173 0 0.0%
Sema.DefaultArgumentTypeRequest 8,991 8,991 0 0.0%
Sema.DefaultDefinitionTypeRequest 575 575 0 0.0%
Sema.DefaultInitializerIsolation 773,137 773,137 0 0.0%
Sema.DefaultTypeRequest 360,060 360,060 0 0.0%
Sema.DerivativeAttrOriginalDeclRequest 0 0 0 0.0%
Sema.DifferentiableAttributeTypeCheckRequest 0 0 0 0.0%
Sema.DirectLookupRequest 130,863,652 130,864,191 539 0.0%
Sema.DirectOperatorLookupRequest 1,683,875 1,683,875 0 0.0%
Sema.DirectPrecedenceGroupLookupRequest 685,860 685,860 0 0.0%
Sema.DistributedModuleIsAvailableRequest 33 33 0 0.0%
Sema.DynamicallyReplacedDeclRequest 3,923,737 3,923,737 0 0.0%
Sema.EnumElementExprPatternRequest 16 16 0 0.0%
Sema.EnumRawTypeRequest 12,702 12,702 0 0.0%
Sema.EnumRawValuesRequest 12,643 12,643 0 0.0%
Sema.ExistentialConformsToSelfRequest 6,968 6,968 0 0.0%
Sema.ExpandAccessorMacros 697,981 697,981 0 0.0%
Sema.ExpandBodyMacroRequest 421,233 421,233 0 0.0%
Sema.ExpandChildTypeRefinementContextsRequest 433,742 433,742 0 0.0%
Sema.ExpandExtensionMacros 149,790 149,790 0 0.0%
Sema.ExpandMacroExpansionDeclRequest 0 0 0 0.0%
Sema.ExpandMacroExpansionExprRequest 0 0 0 0.0%
Sema.ExpandMemberAttributeMacros 9,762,484 9,762,484 0 0.0%
Sema.ExpandPeerMacroRequest 3,931,052 3,931,052 0 0.0%
Sema.ExpandPreambleMacroRequest 421,233 421,233 0 0.0%
Sema.ExpandSynthesizedMemberMacroRequest 138,524 138,524 0 0.0%
Sema.ExplicitCaughtTypeRequest 25,989 25,989 0 0.0%
Sema.ExprPatternMatchRequest 66,931 66,931 0 0.0%
Sema.ExtendedNominalRequest 69,143 69,143 0 0.0%
Sema.ExtendedTypeRequest 68,833 68,833 0 0.0%
Sema.ExternalMacroDefinitionRequest 2 2 0 0.0%
Sema.FragileFunctionKindRequest 1,402,655 1,402,655 0 0.0%
Sema.FunctionOperatorRequest 10,009 10,009 0 0.0%
Sema.GenericParamListRequest 1,885,235 1,885,235 0 0.0%
Sema.GenericSignatureRequest 1,335,995 1,335,995 0 0.0%
Sema.GetDestructorRequest 24,507 24,507 0 0.0%
Sema.GetDistributedActorArgumentDecodingMethodRequest 19 19 0 0.0%
Sema.GetDistributedActorIDPropertyRequest 32 32 0 0.0%
Sema.GetDistributedActorImplicitCodableRequest 56 56 0 0.0%
Sema.GetDistributedActorInvocationDecoderRequest 19 19 0 0.0%
Sema.GetDistributedActorSystemPropertyRequest 28 28 0 0.0%
Sema.GetDistributedActorSystemRemoteCallFunctionRequest 8 8 0 0.0%
Sema.GetDistributedRemoteCallArgumentInitFunctionRequest 5 5 0 0.0%
Sema.GetDistributedRemoteCallTargetInitFunctionRequest 5 5 0 0.0%
Sema.GetDistributedTargetInvocationDecoderDecodeNextArgumentFunctionRequest 5 5 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordArgumentFunctionRequest 5 5 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordErrorTypeFunctionRequest 3 3 0 0.0%
Sema.GetDistributedTargetInvocationEncoderRecordReturnTypeFunctionRequest 4 4 0 0.0%
Sema.GetDistributedTargetInvocationResultHandlerOnReturnFunctionRequest 1 1 0 0.0%
Sema.GetDistributedThunkRequest 42 42 0 0.0%
Sema.GetSourceFileAsyncNode 70 70 0 0.0%
Sema.GlobalActorAttributeRequest 4,541,120 4,541,120 0 0.0%
Sema.GlobalActorInstanceRequest 420 420 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 9,533 9,533 0 0.0%
Sema.HasCircularRawValueRequest 12,607 12,607 0 0.0%
Sema.HasDefaultInitRequest 46,047 46,047 0 0.0%
Sema.HasDynamicCallableAttributeRequest 12,471 12,471 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 149,754 149,754 0 0.0%
Sema.HasImportsMatchingFlagRequest 67,986 67,986 0 0.0%
Sema.HasInitAccessorRequest 921,784 921,784 0 0.0%
Sema.HasIsolatedSelfRequest 5,855,955 5,855,955 0 0.0%
Sema.HasMemberwiseInitRequest 21,739 21,739 0 0.0%
Sema.HasMissingDesignatedInitializersRequest 20,686 20,686 0 0.0%
Sema.HasSelfOrAssociatedTypeRequirementsRequest 8,623 8,623 0 0.0%
Sema.HasStorageRequest 1,788,231 1,788,231 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 46,047 46,047 0 0.0%
Sema.IDEInspectionFileRequest 0 0 0 0.0%
Sema.ImplementsAttrProtocolRequest 0 0 0 0.0%
Sema.ImplicitKnownProtocolConformanceRequest 54,326 54,326 0 0.0%
Sema.InferredGenericSignatureRequest 100,618 100,618 0 0.0%
Sema.InheritedDeclsReferencedRequest 1,246,667 1,246,667 0 0.0%
Sema.InheritedProtocolsRequest 122,704 122,704 0 0.0%
Sema.InheritedTypeRequest 239,476 239,476 0 0.0%
Sema.InheritsSuperclassInitializersRequest 19,411 19,411 0 0.0%
Sema.InitAccessorPropertiesRequest 47,399 47,399 0 0.0%
Sema.InitAccessorReferencedVariablesRequest 0 0 0 0.0%
Sema.InitKindRequest 91,703 91,703 0 0.0%
Sema.InterfaceTypeRequest 5,164,699 5,164,699 0 0.0%
Sema.InvertibleAnnotationRequest 374,623 374,623 0 0.0%
Sema.IsABICompatibleOverrideRequest 207,440 207,440 0 0.0%
Sema.IsAccessorTransparentRequest 357,753 357,753 0 0.0%
Sema.IsActorRequest 398,926 398,926 0 0.0%
Sema.IsCCompatibleFuncDeclRequest 0 0 0 0.0%
Sema.IsCallAsFunctionNominalRequest 6,441 6,441 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDeclRefinementOfRequest 35,168 35,168 0 0.0%
Sema.IsDefaultActorRequest 31,111 31,111 0 0.0%
Sema.IsDistributedActorRequest 459,858 459,858 0 0.0%
Sema.IsDynamicRequest 1,883,767 1,883,767 0 0.0%
Sema.IsEscapableRequest 0 0 0 0.0%
Sema.IsFinalRequest 1,494,345 1,494,345 0 0.0%
Sema.IsFunctionBodySkippedRequest 816,775 816,775 0 0.0%
Sema.IsGetterMutatingRequest 479,963 479,963 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,663,837 2,663,837 0 0.0%
Sema.IsNonUserModuleRequest 365 365 0 0.0%
Sema.IsNoncopyableRequest 0 0 0 0.0%
Sema.IsObjCRequest 1,616,264 1,616,264 0 0.0%
Sema.IsSafeUseOfCxxDecl 0 0 0 0.0%
Sema.IsSetterMutatingRequest 466,981 466,981 0 0.0%
Sema.IsSingleValueStmtRequest 350,920 350,920 0 0.0%
Sema.IsStaticRequest 796,621 796,621 0 0.0%
Sema.LazyStoragePropertyRequest 595 595 0 0.0%
Sema.LocalDiscriminatorsRequest 404,310 404,310 0 0.0%
Sema.LookupAllConformancesInContextRequest 161,046 161,046 0 0.0%
Sema.LookupConformanceInModuleRequest 42,685,787 42,687,109 1,321 0.0%
Sema.LookupInModuleRequest 3,408,214 3,408,214 0 0.0%
Sema.LookupInfixOperatorRequest 67,531 67,531 0 0.0%
Sema.LookupPostfixOperatorRequest 37 37 0 0.0%
Sema.LookupPrecedenceGroupRequest 28,905 28,905 0 0.0%
Sema.LookupPrefixOperatorRequest 206 206 0 0.0%
Sema.MacroDefinitionRequest 4 4 0 0.0%
Sema.MangleLocalTypeDeclRequest 294 294 0 0.0%
Sema.MemberwiseInitPropertiesRequest 47,399 47,399 0 0.0%
Sema.ModuleImplicitImportsRequest 1,330 1,330 0 0.0%
Sema.ModuleLibraryLevelRequest 107 107 0 0.0%
Sema.ModuleQualifiedLookupRequest 666,428 666,428 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 19,272,970 19,272,970 0 0.0%
Sema.NamingPatternRequest 51,482 51,482 0 0.0%
Sema.NeedsNewVTableEntryRequest 765,076 765,076 0 0.0%
Sema.NumAccessorBodiesSynthesized 256,885 256,885 0 0.0%
Sema.NumAccessorsSynthesized 284,337 284,337 0 0.0%
Sema.NumConformancePathsRecorded 808,962 808,962 0 0.0%
Sema.NumConformancesDeserialized 856,501 856,501 0 0.0%
Sema.NumConstraintScopes 59,081,693 59,081,672 -21 -0.0%
Sema.NumConstraintsConsideredForEdgeContraction 2,360,617 2,360,617 0 0.0%
Sema.NumCrossImportsChecked 0 0 0 0.0%
Sema.NumCrossImportsFound 0 0 0 0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 12,823,107 12,823,107 0 0.0%
Sema.NumDeclsTypechecked 2,044,916 2,044,916 0 0.0%
Sema.NumLazyIterableDeclContexts 2,111,145 2,111,145 0 0.0%
Sema.NumLazyRequirementSignatures 153,589 153,589 0 0.0%
Sema.NumLazyRequirementSignaturesLoaded 113,464 113,464 0 0.0%
Sema.NumLeafScopes 47,191,486 47,191,473 -13 -0.0%
Sema.NumRequirementMachineCompletionSteps 4,193,014 4,193,014 0 0.0%
Sema.NumRequirementMachineUnifiedConcreteTerms 340,305 340,305 0 0.0%
Sema.NumRequirementMachines 393,417 393,417 0 0.0%
Sema.NumTypesDeserialized 5,547,437 5,547,437 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 1,953,294 1,953,294 0 0.0%
Sema.ObjCInterfaceAndImplementationRequest 1,477,809 1,477,809 0 0.0%
Sema.OpaqueReadOwnershipRequest 258,773 258,773 0 0.0%
Sema.OpaqueResultTypeRequest 405 405 0 0.0%
Sema.OperatorPrecedenceGroupRequest 441 441 0 0.0%
Sema.OverriddenDeclsRequest 2,987,217 2,987,217 0 0.0%
Sema.ParamSpecifierRequest 1,161,299 1,161,299 0 0.0%
Sema.PatternBindingCheckedAndContextualizedInitRequest 275,035 275,035 0 0.0%
Sema.PatternBindingEntryRequest 415,767 415,767 0 0.0%
Sema.PatternTypeRequest 540,036 540,036 0 0.0%
Sema.PolymorphicEffectKindRequest 647,949 647,949 0 0.0%
Sema.PolymorphicEffectRequirementsRequest 40 40 0 0.0%
Sema.PotentialMacroExpansionsInContextRequest 1,454,981 1,454,981 0 0.0%
Sema.PreCheckFunctionBodyRequest 406,522 406,522 0 0.0%
Sema.PreCheckResultBuilderRequest 999 999 0 0.0%
Sema.PreCheckReturnStmtRequest 565,395 565,395 0 0.0%
Sema.PrimaryAssociatedTypesRequest 8,047 8,047 0 0.0%
Sema.PrimarySourceFilesRequest 1,330 1,330 0 0.0%
Sema.PropertyWrapperAuxiliaryVariablesRequest 1,817,976 1,817,976 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 10,600 10,600 0 0.0%
Sema.PropertyWrapperInitializerInfoRequest 466,080 466,080 0 0.0%
Sema.PropertyWrapperLValuenessRequest 965 965 0 0.0%
Sema.PropertyWrapperMutabilityRequest 477,548 477,548 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 146 146 0 0.0%
Sema.ProtocolDependenciesRequest 101,932 101,932 0 0.0%
Sema.ProtocolRequirementsRequest 20,337 20,337 0 0.0%
Sema.ProtocolRequiresClassRequest 10,009 10,009 0 0.0%
Sema.ProvideDefaultImplForRequest 20,763 20,763 0 0.0%
Sema.QualifiedLookupRequest 5,676,050 5,676,148 98 0.0%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RawCommentRequest 689,483 689,483 0 0.0%
Sema.RenamedDeclRequest 3,602 3,602 0 0.0%
Sema.RequirementRequest 98,262 98,262 0 0.0%
Sema.RequirementSignatureRequest 124,649 124,649 0 0.0%
Sema.RequiresOpaqueAccessorsRequest 1,655,648 1,655,648 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 259,684 259,684 0 0.0%
Sema.ResolveEffectiveMemberwiseInitRequest 0 0 0 0.0%
Sema.ResolveImplicitMemberRequest 607,156 607,156 0 0.0%
Sema.ResolveMacroConformances 4 4 0 0.0%
Sema.ResolveMacroRequest 14,136 14,136 0 0.0%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResolveRawLayoutLikeTypeRequest 0 0 0 0.0%
Sema.ResolveTypeEraserTypeRequest 0 0 0 0.0%
Sema.ResolveTypeRequest 2,832,690 2,832,690 0 0.0%
Sema.ResultBuilderTypeRequest 478,336 478,336 0 0.0%
Sema.ResultTypeRequest 586,594 586,594 0 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SPIGroupsRequest 2,566,637 2,566,637 0 0.0%
Sema.ScopedImportLookupRequest 451 451 0 0.0%
Sema.SelfAccessKindRequest 456,209 456,209 0 0.0%
Sema.SelfBoundsFromGenericSignatureRequest 37,314 37,314 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 557,030 557,030 0 0.0%
Sema.SemanticAvailableRangeAttrRequest 5,772 5,772 0 0.0%
Sema.SemanticBriefCommentRequest 193,275 193,275 0 0.0%
Sema.SemanticDeclAttrsRequest 105,891 105,891 0 0.0%
Sema.SemanticUnavailableAttrRequest 1,380,657 1,380,657 0 0.0%
Sema.SerializeAttrGenericSignatureRequest 480 480 0 0.0%
Sema.SetterAccessLevelRequest 207,741 207,741 0 0.0%
Sema.SimpleDidSetRequest 479,567 479,567 0 0.0%
Sema.SpecializeAttrTargetDeclRequest 20,195 20,195 0 0.0%
Sema.StorageImplInfoRequest 1,680,056 1,680,056 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 49,036 49,036 0 0.0%
Sema.StoredPropertiesRequest 162,130 162,130 0 0.0%
Sema.StructuralRequirementsRequest 11,206 11,206 0 0.0%
Sema.StructuralTypeRequest 598 598 0 0.0%
Sema.SuperclassDeclRequest 112,725 112,725 0 0.0%
Sema.SuperclassTypeRequest 30,966 30,966 0 0.0%
Sema.SynthesizeAccessorRequest 284,337 284,337 0 0.0%
Sema.SynthesizeDefaultInitRequest 3,751 3,751 0 0.0%
Sema.SynthesizeMainFunctionRequest 135,422 135,422 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,952 3,952 0 0.0%
Sema.TangentStoredPropertyRequest 0 0 0 0.0%
Sema.TypeAliasRequirementsRequest 11,206 11,206 0 0.0%
Sema.TypeCheckASTNodeAtLocRequest 0 0 0 0.0%
Sema.TypeCheckFunctionBodyRequest 734,181 734,181 0 0.0%
Sema.TypeCheckObjCImplementationRequest 0 0 0 0.0%
Sema.TypeCheckSourceFileRequest 34,280 34,280 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 34,204 34,204 0 0.0%
Sema.TypeEraserHasViableInitRequest 0 0 0 0.0%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 6,319 6,319 0 0.0%
Sema.USRGenerationRequest 545,740 545,740 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 88,152 88,152 0 0.0%
Sema.UnderlyingTypeRequest 30,357 30,357 0 0.0%
Sema.UniqueUnderlyingTypeSubstitutionsRequest 609 609 0 0.0%
Sema.UnqualifiedLookupRequest 3,336,756 3,336,772 16 0.0%
Sema.ValidatePrecedenceGroupRequest 249,930 249,930 0 0.0%
Sema.ValueWitnessRequest 40,116 40,116 0 0.0%
TBDGen.APIGenRequest 0 0 0 0.0%
TBDGen.GenerateTBDRequest 0 0 0 0.0%
TBDGen.PublicSymbolsRequest 1,267 1,267 0 0.0%
TBDGen.SymbolSourceMapRequest 0 0 0 0.0%

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test source compatibility debug

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test source compatibility release

@ahoppen ahoppen removed their request for review January 8, 2024 21:25
@slavapestov
Copy link
Contributor

@AnthonyLatsis do you mind rebasing this? We should get it landed.

@AnthonyLatsis
Copy link
Collaborator Author

@slavapestov Gladly!

@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from bc4e92c to aa5d5c5 Compare February 8, 2024 18:23
@AnthonyLatsis
[NFC] MemberTypeRepr: getBaseComponent() → getRoot()
d6fd424
@AnthonyLatsis
[NFC] Introduce TypeRepr::isSimpleUnqualifiedIdentifier to simplify…
fd4094c 
… some code
@AnthonyLatsis
[NFC] Parse: Refactor for recursive MemberTypeRepr representation
a239768
@AnthonyLatsis
[NFC] Migrator: Refactor for recursive MemberTypeRepr representation
e118026
@AnthonyLatsis
[NFC] AST/NameLookup: Refactor for recursive MemberTypeRepr represe…
e5413c9 
…ntation
@AnthonyLatsis
[NFC] AST/ASTDumper: Refactor for recursive MemberTypeRepr represen…
d9777a0 
…tation
@AnthonyLatsis
[NFC] AST: Refactor for recursive MemberTypeRepr representation
8bea09d
@AnthonyLatsis
[NFC] ASTGen: Refactor for recursive MemberTypeRepr representation
de499d1
@AnthonyLatsis
[NFC] IDE: Refactor for recursive MemberTypeRepr representation
fe7cb56
@AnthonyLatsis
[NFC] Sema/TypeCheckAvailability: Refactor for recursive `MemberTypeR…
6818207 
…epr` representation
@AnthonyLatsis
[NFC] Sema/TypeCheckPattern: Refactor for recursive MemberTypeRepr …
6410e58 
…representation
@AnthonyLatsis
[NFC] Sema/TypeCheckType: Refactor for recursive MemberTypeRepr rep…
bbf03c0 
…resentation
@AnthonyLatsis
[NFC] Sema: Refactor for recursive MemberTypeRepr representation
14d38e7
@AnthonyLatsis
TypeCheckType: Tidy up and rename ExistentialTypeVisitor
cdfe5a0
@AnthonyLatsis
AST/ASTWalker: Refactor for recursive MemberTypeRepr representation
ef93134
@AnthonyLatsis
[NFC] AST: Actually remodel MemberTypeRepr to be recursive
8970afc
@AnthonyLatsis AnthonyLatsis force-pushed the recursive-member-typerepr branch from aa5d5c5 to 8970afc Compare February 9, 2024 14:40
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please test source compatibility release

@AnthonyLatsis
Copy link
Collaborator Author

@slavapestov Are we ready to merge this?

@slavapestov
Copy link
Contributor

I dropped the ball, again. Sorry @AnthonyLatsis. Let's run the tests one more time.

@slavapestov
Copy link
Contributor

@swift-ci Please test

@slavapestov
Copy link
Contributor

@swift-ci Please test source compatibility

@AnthonyLatsis
Copy link
Collaborator Author

Hakuna matata, thanks for taking a look. The UPASS is unrelated.

@slavapestov slavapestov merged commit 1c24b88 into swiftlang:main Feb 16, 2024
@AnthonyLatsis AnthonyLatsis deleted the recursive-member-typerepr branch February 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishknight hamishknight hamishknight approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@zoecarver zoecarver Awaiting requested review from zoecarver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnthonyLatsis @slavapestov @hamishknight