[ConstraintSystem] Modernization of key path application handling #70007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se new locator element
…out` Subscripts do not support inout parameters.
…ariable The resulting type is no longer in use so there is no need to create a type variable and a constraint to perform the operation.
…iable Previous `FunctionArgument` locator didn't make sense because this type variable doesn't actually represent a parameter but rather a value generic parameter of the key path subscript index parameter.
…diagnostic mode This parameter doesn't allow direct holes because it always replies on the contextual type (if it's not present the hole should be propagated to it), so if we know that the argument is some invalid existential value (one without a superclass) let's allow binding to it only in diagnostic mode which would be detected and diagnosed as a contextual mismatch.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test macOS platform |
3 similar comments
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TVO_CanBindToInOutfrom key path subscript index which is never the case