[SILGen/DI] Add support for init accessor properties without setters #67107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor our following logic: - Applying setter to its base value - `newValue` emission This would be useful for init accessor emission as well.
… component The logic is going to be shared when we start supporting init accessor properties without `set`.
…cial write strategy Such properties could be mutated only within initializer context so they can employ a special "init accessor" strategy.
…ies without a setter Implement "init accessor" component emission which is paired with "init accessor" write strategy. Use `SILUndef` for a "setter" operand of an "assign_or_init" instruction in cases when property with init accessor doesn't have a setter. DI would detect re-initialization attempts to produce diagnostics.
…erenced by `assign_or_init` instruction This is going to be used by DI diagnostics.
…ty with a setter Init accessor properties without setters behave just like `let` stored properties and can only be initialized once.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
jckarter
approved these changes
Jul 5, 2023
hborla
approved these changes
Jul 7, 2023
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.assign_or_initemission for init accessors intoInitAccessorComponentInitAccessorwrite strategy for init accessor properties without settersletproperties).