Fix missing indexing data when using Self initializer #65512
Conversation
|
@swift-ci please test |
|
One alternative here would be to make the underlying decl ref not implicit, but I figured that might be more significant of a change. The only thing I'm not sure about this is if there is another time where things could be this same shape since I can't explicitly check that |
| struct Foo { | ||
| init() {} // CHECK: [[@LINE]]:3 | constructor/Swift | init() | [[init_USR:.*]] | Def,RelChild | rel: 1 | ||
|
|
||
| static func bar() -> Self { |
There was a problem hiding this comment.
Self in this context also isn't indexed yet, I figured that could potentially be done as a follow up. I also think that one is a bit less important since the type it's referencing will always have another reference in the same file, where the initializer being referenced could be in another file
turns out just using the type's name directly is the same shape, so I need to figure out how to narrow it down |
|
There's actually no difference in the AST (at least via -dump-ast) in that case, so I think I do have to solve this somewhere else |
keith
force-pushed
the
ks/fix-missing-indexing-data-when-using-self-initializer
branch
from
2ff3f34 to
9773bdd
Compare
|
@swift-ci please test |
keith
force-pushed
the
ks/fix-missing-indexing-data-when-using-self-initializer
branch
from
9773bdd to
8a9f6ef
Compare
|
@swift-ci please test |
|
@swift-ci please test macOS Platform |
keith
force-pushed
the
ks/fix-missing-indexing-data-when-using-self-initializer
branch
4 times, most recently
from
484b753 to
ae77ad3
Compare
keith
force-pushed
the
ks/fix-missing-indexing-data-when-using-self-initializer
branch
from
ae77ad3 to
1d3a9ba
Compare
|
@swift-ci please test and merge |
Fixes: swiftlang#64686 (cherry picked from commit 1d3a9ba / swiftlang#65512)
Fixes: #64686