-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Concurrency] Verify the #if guards around moveonly Job #64477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please clean smoke test |
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
@swift-ci please clean smoke test macOS |
git checkout failed. @swift-ci please clean smoke test macOS |
@swift-ci please clean smoke test macOS |
Still seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems #63569 tests did pass but actually were wrong somehow...? Or it could be an issue that other runs should do a
clean
potentially... 😮💨Checking all those #if consistently is quite tricky.
This should also be correct now in the normal main build as well as freestnading mode.