Skip to content

[Concurrency] Verify the #if guards around moveonly Job #64477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 20, 2023

It seems #63569 tests did pass but actually were wrong somehow...? Or it could be an issue that other runs should do a clean potentially... 😮‍💨

Checking all those #if consistently is quite tricky.

This should also be correct now in the normal main build as well as freestnading mode.

@ktoso
Copy link
Contributor Author

ktoso commented Mar 20, 2023

@swift-ci please clean smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 20, 2023

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please clean test with toolchain and preset

@ktoso ktoso requested a review from gottesmm March 20, 2023 04:07
@ktoso ktoso changed the title [Concurrency] fix the #if guards around moveonly Job [Concurrency] Verify the #if guards around moveonly Job Mar 20, 2023
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Mar 20, 2023
@ktoso
Copy link
Contributor Author

ktoso commented Mar 20, 2023

 error: 'miscellaneous_atmainsupport': Invalid manifest (compiled with: ["/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/toolchain-macosx-x86_64/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc", "-vfsoverlay", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/TemporaryDirectory.2x6fhP/vfs.yaml", "-L", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-target", "x86_64-apple-macosx11.0", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk", "-F", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/Library/Frameworks", "-I", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-L", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/usr/lib", "-swift-version", "5", "-I", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/lib/swift/pm/ManifestAPI", "-sdk", "/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk", "-package-description-version", "5.5.0", "-module-cache-path", "/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/build/buildbot_incremental/swiftpm-macosx-x86_64/x86_64-apple-macosx/release", "/private/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/Miscellaneous_AtMainSupport.47BIHQ/Miscellaneous_AtMainSupport/Package.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/TemporaryDirectory.5fBpGZ/miscellaneous_atmainsupport-manifest"])

    /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/lib/swift/Foundation.swiftmodule/x86_64-apple-macos.swiftinterface:4:8: error: no such module 'Combine'
    import Combine
           ^
    /private/var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/Miscellaneous_AtMainSupport.47BIHQ/Miscellaneous_AtMainSupport/Package.swift:1:8: error: failed to build module 'Foundation'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.5 (swiftlang-1300.0.27.6 clang-1300.0.27.2)', while this compiler is 'Apple Swift version 5.9-dev (LLVM 2f10ca61f4018fd, Swift ca063bbc0bf81bd)'). Please select a toolchain which matches the SDK.
    import Foundation
           ^
    "Test Case '-[CommandsTests.BuildToolTests testAtMainSupport]' failed (21.010 seconds).
Test Suite 'BuildToolTests' failed at 2023-03-20 05:44:04.412.
	 Executed 1 test, with 1 failure (1 unexpected) in 21.010 (21.010) seconds
Test Suite 'SwiftPMPackageTests.xctest' failed at 2023-03-20 05:44:04.412.
	 Executed 1 test, with 1 failure (1 unexpected) in 21.010 (21.010) seconds
Test Suite 'Selected tests' failed at 2023-03-20 05:44:04.412.
	 Executed 1 test, with 1 failure (1 unexpected) in 21.010 (21.011) seconds**** FAILURE EXECUTING SUBPROCESS ****

@swift-ci please clean smoke test macOS

@ktoso
Copy link
Contributor Author

ktoso commented Mar 20, 2023

git checkout failed.

@swift-ci please clean smoke test macOS

@ktoso
Copy link
Contributor Author

ktoso commented Mar 20, 2023

@swift-ci please clean smoke test macOS

@ktoso
Copy link
Contributor Author

ktoso commented Mar 20, 2023

Still seems good.

@ktoso ktoso merged commit 24a38fc into swiftlang:main Mar 20, 2023
@ktoso ktoso deleted the wip-freestanding-moveonly-issues branch March 20, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant