Use libcxx from Darwin SDKs when building LLVM and Swift (LLVM product) #62159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... function This is done in anticipation of switching to use headers from the SDKs for Darwin, so to not grow any further the `build` method.
Those are present since Xcode 12.5, so we don't need to copy them anymore from the toolchain In this scenario, clean up any existing symlink in incremental builds to avoid masking or causing errors in the future. Addresses rdar://102387542
|
Waiting a bit before starting testing to see if #62139 gets merged first |
compnerd
approved these changes
Nov 17, 2022
|
@swift-ci please test |
|
@swift-ci please test Apple Silicon |
|
@swift-ci please build toolchain |
|
@swift-ci please build toolchain macOS |
|
The macOS toolchain failure is happening in the nightly job as well (https://ci.swift.org/job/oss-swift-package-macos/1239/) |
|
@swift-ci please build toolchain macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are present since Xcode 12.5, so we don't need to copy them
anymore from the toolchain
In this scenario, clean up any existing symlink in incremental builds to
avoid masking or causing errors in the future.
Took the chance to extract this logic to a different function in an attempt to improve readability
To ease review, the PR has two commits -- the first to extract the logic as is (showing that I did not alter the existing logic) and the second one to change its behaviour for Darwin (and address a minor issue when printing about the creation of symlinks)
Addresses rdar://102387542