RequirementMachine: Leave behind conflicting requirements in the minimized signature #61064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,16 @@ | |||
| // RUN: %target-typecheck-verify-swift | |||
There was a problem hiding this comment.
Do you mind sticking to the issue-* format for file names? This is the one I'm planning to use once I start renaming all the sr* files.
slavapestov
force-pushed
the
rqm-conflicting-rules-can-remain
branch
from
746050b to
f100708
Compare
…mized signature Requirement lowering only expects that it won't see two requirements of the same kind (except for conformance requirements). So only mark those as conflicting. This addresses a crash-on-invalid and improves diagnostics for move-only generics, because a conflict won't drop the copyability of a generic parameter and expose a move-only-naive user to confusing error messages. Fixes swiftlang#61031. Fixes swiftlang#63997. Fixes rdar://problem/111991454.
slavapestov
force-pushed
the
rqm-conflicting-rules-can-remain
branch
from
f100708 to
70c9f8a
Compare
slavapestov
requested review from
hborla,
ahoppen,
bnbarham,
hamishknight,
rintaro and
xedin
as code owners
slavapestov
changed the title
|
@swift-ci Please smoke test |
ahoppen
reviewed
Feb 17, 2024
Comment on lines
+240
to
+241
| // EXT_ASSOC_MEMBER_2: Begin completions, {{.*}} items | ||
| // EXT_ASSOC_MEMBER_2: Keyword/None: Type[#Int.Type#]; |
There was a problem hiding this comment.
This is a regression. Do you know how it used to get parsed or why the behavior might have changed?
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Feb 21, 2024
…ht-hand side in generic where clause Fixes the issue in swiftlang#61064 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement lowering only expects that it won't see two requirements
of the same kind (except for conformance requirements). So only mark
those as conflicting.
This addresses a crash-on-invalid and improves diagnostics for
move-only generics, because a conflict won't drop the copyability
of a generic parameter and expose a move-only-naive user to
confusing error messages.
Fixes #61031.
Fixes #63997.
Fixes rdar://problem/111991454.