ABIChecker: teach ABI descriptor JSON to also keep track of constant values known at compile-time #41367
Conversation
…values known at compile-time Emitted at the emit-module step, ABI descriptor is of an entensible JSON format. This patch sets up a segment in the file to also keep track of all compile-time constant values for other tools to consume. As the initial step, we only keep track of string literals in the source files.
|
@swift-ci please smoke test |
| struct ConstExprInfo { | ||
| StringRef filePath; | ||
| ConstKind kind; | ||
| unsigned offset = 0; |
There was a problem hiding this comment.
As far as I understand, offset here is measured in number of characters from the start of the buffer, and length is the difference between token locs of the Expr where we found this value.
I'm not sure these are useful values to have here, what's the thinking behind including them?
There was a problem hiding this comment.
This is a great start for having the infrastructure to extract constant values.
I think the next most-important missing piece is how to also include information about the context of what these values are.
For example, clients may really want to know values of constant properties of their types.
For something like:
struct Foo {
let bar: String = "abc"
}
We should be able to extract the value of abc but also the fact that it is used to initialize Foo.bar.
Emitted at the emit-module step, ABI descriptor is of an entensible JSON format. This patch sets
up a segment in the file to also keep track of all compile-time constant values for other tools
to consume. As the initial step, we only keep track of string literals in the source files.