Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary one-time recompile of stdlib with -enable-ossa-flag #39516

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Fix unnecessary one-time recompile of stdlib with -enable-ossa-flag #39516

merged 2 commits into from
Oct 5, 2021

Conversation

meg-gupta
Copy link
Contributor

This includes a bit in the module format to represent if the module was compiled with -enable-ossa-modules flag. When compiling a client module with -enable-ossa-modules flag, all dependent modules are checked for this bit, if not on, recompilation is triggered with -enable-ossa-modules.

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b0e31ea334929b1aa8487262c1fa5b712ed82926

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b0e31ea334929b1aa8487262c1fa5b712ed82926

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3400f2fb75863e8bf646c6761c542f9e96e09b1a

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3400f2fb75863e8bf646c6761c542f9e96e09b1a

@meg-gupta meg-gupta marked this pull request as ready for review September 30, 2021 19:05
@meg-gupta meg-gupta changed the title [WIP] Fix unnecessary one-time recompile of stdlib with -enable-ossa-flag Fix unnecessary one-time recompile of stdlib with -enable-ossa-flag Sep 30, 2021
@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#3316

@swift-ci test

@artemcm artemcm requested a review from xymus September 30, 2021 19:08
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e47bc69532e0a38ee153e9e4eb1352db9c8974c0

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e47bc69532e0a38ee153e9e4eb1352db9c8974c0

@meg-gupta
Fix unnecessary one-time recompile of stdlib with -enable-ossa-flag
056b17d 
This includes a bit in the module format to represent if the module was
compiled with -enable-ossa-modules flag. When compiling a client module
with -enable-ossa-modules flag, all dependent modules are checked for this bit,
if not on, recompilation is triggered with -enable-ossa-modules.
@meg-gupta
Updated tests
03829ce
@meg-gupta meg-gupta force-pushed the fixenableossaflagpr branch from e47bc69 to 03829ce Compare October 1, 2021 02:07
@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#3316

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2021

Build failed
Swift Test Linux Platform
Git Sha - 03829ce

@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2021

Build failed
Swift Test OS X Platform
Git Sha - 03829ce

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#3316

@swift-ci test

@meg-gupta
Copy link
Contributor Author

@swift-ci test windows platform

artemcm
artemcm approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good!

@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#3316

@swift-ci test windows platform

1 similar comment
@meg-gupta
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#3316

@swift-ci test windows platform

@meg-gupta meg-gupta mentioned this pull request Oct 2, 2021
Merged
@atrick
Copy link
Contributor

atrick commented Oct 4, 2021

@meg-gupta Thanks! This is really important for adoption to have working well. Looks like great work to me.

@meg-gupta meg-gupta merged commit f458d9b into swiftlang:main Oct 5, 2021
@medismailben medismailben mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@8704dev 8704dev 8704dev approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@nkcsgexi nkcsgexi Awaiting requested review from nkcsgexi

@atrick atrick Awaiting requested review from atrick

@xymus xymus Awaiting requested review from xymus xymus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meg-gupta @swift-ci @atrick @artemcm @8704dev