Migrate from UnsafePointer<Void> to UnsafeRawPointer. #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
There are a few test case failures that I still need to investigate. Such as: |
As proposed in SE-0107: UnsafeRawPointer. `void*` imports as `UnsafeMutableRawPointer`. `const void*` imports as `UnsafeRawPointer`. Occurrences of `UnsafePointer<Void>` are replaced with UnsafeRawPointer.
This requires explicit memory binding in several places, particularly in NSData and CoreAudio.
This is unfortunately necessary for assignment between types imported from C.
| // FIXME: Why is this necessary? | ||
| @_transparent | ||
| public init(_ other: Unsafe${Mutable}RawPointer) { | ||
| self._rawValue = other._rawValue |
atrick
changed the title
|
@swift-ci Please smoke test OS X. |
This was referenced Jul 26, 2016
|
Depends on corelibs-libdispatch PR: Depends on corelibs-foundation PR: |
|
build-toolchain passes on both darwin and linux. |
atrick
added a commit
that referenced
this pull request
Jul 26, 2016
This reverts commit ece0951. This results in lldb failues on linux that I can't readily debug. Backing out until they can be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.