[AST] Add method to create an implicit SwitchStmt
#36973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(typo in the commit message |
There are a number of occurances that create implicit `Switch`s by passing `SourceLoc()` for all location paramters. Refactor those occurances out to a separate `createImplicit` method that automatically fills the locations with invalid source locations.
ahoppen
force-pushed
the
pr/create-implicit-switch-stmt
branch
from
c3c6fb9 to
aa69529
Compare
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test macOS |
ahoppen
changed the title
SwiftStmtSwitchStmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of occurances that create implicit
SwitchStmts by passingSourceLoc()for all location paramters. Refactor those occurrences out to a separatecreateImplicitmethod that automatically fills the locations with invalid source locations.As discussed here: #36930 (comment).