[Concurrency] Fix try-await fix-it #36763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
kavon
approved these changes
Apr 6, 2021
We want to be able to put the `try` before the `await`, so we need to make it available where we emit the diagnostics and fix-its. The easiest way to do that was through the context object.
Actually put the try fix-it before the await if it is available.
Updating the test to verify that we're putting the try fix-its in the right place.
etcwilde
force-pushed
the
ewilde/fix-try-await-fix-it
branch
from
9a6f067 to
45c81c2
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
|
The Windows failure is an unrelated change that was made to lldb. compnerd and kastiglione have two PR’s with fixes that are racing each other. Compnerd’s is swiftlang/llvm-project#2808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the order that the fix-it for
tryis emitted. It was prepending it to the call, but if an await is present, it should go before that instead. e.gtry await foo()instead ofawait try foo().Resolves: rdar://71058133