-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditionalize 'num_extra_inhabitants' in 64 bit platforms's tests #33136
Conditionalize 'num_extra_inhabitants' in 64 bit platforms's tests #33136
Conversation
@vedantk @adrian-prantl In this PR I only substituted the raw values by the new variables in the tests that are passing on Linux. I can also do that to the tests which are not passing. I think that'd be better, so we don't have 2 different ways to refer to the 64-bit |
If I understand your question correctly, I would prefer to update all tests at once, even the ones currently not running. |
ce80a1c
to
b3cb548
Compare
@adrian-prantl Ok, pushed! |
@swift-ci smoke test |
@swift-ci test |
Build failed |
Build failed |
b3cb548
to
17baf3f
Compare
17baf3f
to
1e0e044
Compare
@swift-ci smoke test |
1e0e044
to
4051e11
Compare
@swift-ci smoke test |
4051e11
to
39f958e
Compare
@swift-ci smoke test |
It looks like it failed to build SwiftPM:
Should I just rebase on top of current master? |
You don't necessarily need to rebase. You could also just merge current master. Either way, it's a good idea to do one or the other every week or so to make sure that your work is correctly tracking ongoing changes there. That will make it easier to merge your work back into master when it's ready. |
39f958e
to
f72c322
Compare
@swift-ci smoke test |
@swift-ci smoke test OS X platform |
Quoting @tbkka:
The number of extra inhabitants actually depends to some extent on the OS. Apple platforms reserve a 4GB "page zero" on 64 bit platforms in order to help detect 32/64 bit errors. [...] But Linux only reserves a 4K page zero, so there are only 4096 invalid pointer values.
This PR adds variables
num_extra_inhabitants
,num_extra_inhabitants_minus_1
,num_extra_inhabitants_minus_2
andnum_extra_inhabitants_minus_3
, with the proper platform's values, and replaces the usages of those raw values by the variables.It also enables the tests under Linux which are now working thanks to these changes and #32339.