More Python3 lint fixes #32967
Merged
More Python3 lint fixes #32967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the issues addressed include: * Don't use `l` as a variable name (confusable with `1` or `I`) * `print` statement does not exist in Py3, use `print` function instead * Implicit tuple deconstruction in function args is no longer supported, use explicit splat `*` at the call site instead * `xrange` does not exist in Py3, use `range` instead
|
@swift-ci Python lint |
|
@swift-ci Please test |
|
There are only a couple of remaining Python3 lint issues in the tree. I'll work through those after this gets merged. |
|
Build failed |
compnerd
approved these changes
Jul 18, 2020
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Build failed |
|
The linux failure looks to be unrelated. Trying again. |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
CodaFi
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the issues addressed include:
las a variable name (confusable with1orI)printstatement does not exist in Py3, useprintfunction insteaduse explicit splat
*at the call site insteadxrangedoes not exist in Py3, userangeinstead