[AutoDiff] NFC: reorganize differentiation SILOptimizer files. #30969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gottesmm: could you please review, as a SILOptimizer code owner? |
rxwei
approved these changes
Apr 11, 2020
|
@gottesmm has more feedback on organization. We're discussing at swift-devel.slack.com on the |
dan-zheng
force-pushed
the
autodiff-reorganize
branch
from
10faa5d to
380ebb6
Compare
gottesmm
reviewed
May 4, 2020
dan-zheng
force-pushed
the
autodiff-reorganize
branch
from
380ebb6 to
662d526
Compare
Move differentiation-related SILOptimizer files to
{include/swift,lib}/SILOptimizer/Differentiation/.
This reduces directory nesting and gathers files together.
dan-zheng
force-pushed
the
autodiff-reorganize
branch
from
662d526 to
2276a2e
Compare
|
@swift-ci Please smoke test |
rxwei
pushed a commit
to rxwei/swift
that referenced
this pull request
Jun 3, 2020
…lang#30969) Move differentiation-related SILOptimizer files to {include/swift,lib}/SILOptimizer/Differentiation/. This reduces directory nesting and gathers files together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move differentiation-related SILOptimizer files to
{include/swift,lib}/SILOptimizer/Differentiation/.This reduces directory nesting within
lib/SILOptimizer/and gathers files together.Requested by @gottesmm.
Further cleanup:
[JVP,VJP,Pullback]Emitter. This should minimize their header files to justrun()entry points, eliminating duplication with.cppfiles.