Adding tests for String's replaceSubrange overloads #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinzheng
force-pushed
the
az-stringtests
branch
2 times, most recently
from
f764f84 to
8616e6b
Compare
austinzheng
force-pushed
the
az-stringtests
branch
from
8616e6b to
f92be08
Compare
|
I verified tests pass locally. This PR is ready to be merged (pending CI). |
|
Thank you! Could you also add tests for overloads that take a |
|
@swift-ci Please test |
|
Yep, once this is in I'll make a follow-up PR. |
|
And also |
|
Oh, and could you remove the fixmes that you have resolved from |
|
Yes and yes :). I plan on making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
@gribozavr
Adding tests for
StringsreplaceSubrange()overload forRangetypes. Both variants (input of string, input of character sequence) are tested.Tests pass locally. This PR can be merged whenever.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.