Skip to content

Reapply: [Parser] Decouple the parser from AST creation (part 1) #26403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2019
Merged

Reapply: [Parser] Decouple the parser from AST creation (part 1) #26403

merged 4 commits into from
Aug 1, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jul 30, 2019 •
edited
Loading

Reapply #25193 with fix

@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no
@swift-ci Please test with preset Linux Platform

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no
@swift-ci Please test with preset Linux Platform

@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f2ef7c088d5bc78d65b38be8e48f8752707c753e

@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=RDA,test=no
@swift-ci Please test with preset Linux Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - f2ef7c088d5bc78d65b38be8e48f8752707c753e

@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=RDA,test=no
@swift-ci Please test with preset Linux Platform

@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

@swift-ci Please clean test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - f2ef7c088d5bc78d65b38be8e48f8752707c753e

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f2ef7c088d5bc78d65b38be8e48f8752707c753e

@rintaro
Copy link
Member Author

rintaro commented Jul 30, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no
@swift-ci Please test with preset Linux Platform

@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2019

@swift-ci Please clean test

@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no
@swift-ci Please test with preset Linux Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 27f2f36

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 27f2f36

@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2019

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no
@swift-ci Please test with preset Linux Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96e87d7bbb7d8bf7684034de76d8c048aa673526

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96e87d7bbb7d8bf7684034de76d8c048aa673526

@rintaro
[SyntaxParse] Return dedicated pointer from HiddenLibSyntaxAction
94f0c14 
SyntaxParseActions::recordToken() et al. may return the same pointer
value for different nodes (e.g. `nullptr`). So we cannot use DenseMap to
associate the node from the explicit syntax parsing actions to libSyntax
node. Instead, use a structure that wraps them.
@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2019

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jul 31, 2019

preset=buildbot_incremental_linux,lsan,tools=RDA,stdlib=DA,test=no
@swift-ci Please test with preset Linux Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 98e7a2bffe046d0bf00a7c0f9cabc673915e0868

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 98e7a2bffe046d0bf00a7c0f9cabc673915e0868

@rintaro rintaro merged commit 1a211e6 into swiftlang:master Aug 1, 2019
@rintaro rintaro deleted the gsoc-2019-part1 branch August 1, 2019 16:59
@marcrasi
Copy link

marcrasi commented Aug 9, 2019 •
edited
Loading

I think this might have caused some other memory leaks. I posted details here: https://bugs.swift.org/browse/SR-11287 . Could you take a look? Since you already fixed a few leaks in this change, maybe you'll immediately know where to look for that leak :)

@rintaro
Copy link
Member Author

rintaro commented Aug 9, 2019

I'll look into it. Thanks!

rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#26403 from rintaro/gsoc-2019-part1"
8a03e08 
This reverts commit 1a211e6, reversing
changes made to 482d062.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#26403 from rintaro/gsoc-…
4cd6832 
…2019-part1""

This reverts commit 8a03e08.
@ahoppen ahoppen mentioned this pull request Dec 16, 2020
Closed
@marcrasi marcrasi mannequin mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @swift-ci @marcrasi