-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[tests] Enable several test cases on non-Darwin platforms #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test and merge |
@rintaro Thank you! |
@rintaro Seems like Linux tests failed, could you take a look? |
I'm looking into it. https://ci.swift.org/job/swift-PR-Linux/1551/console
tests.test("basic") {
do {
let s = TestManagedBuffer<LifetimeTracked>.create(0)
expectEqual(1, LifetimeTracked.instances)
}
expectEqual(0, LifetimeTracked.instances)
do {
let s = TestManagedBuffer<LifetimeTracked>.create(10)
expectEqual(0, s.count)
expectLE(10, s.myCapacity)
expectGE(12, s.myCapacity) // allow some over-allocation but not too much
// ^ Failing test |
If we need to relax the bounds by a little bit, feel free to do so. |
That capacity test is dependent on the malloc implementation. It is likely that 13 is the expected result on that Linux version. |
@gparker42 |
@rintaro Bump it to what's needed on your system, and we can bump it further if it is needed for other systems. We just don't want to set it too high, since what's the point in checking at all then. |
@gribozavr OK, updated to |
@swift-ci Please test and merge |
What's in this pull request?
Enable several test cases on non-Darwin platforms.
Before merging this pull request to apple/swift repository: