swift_build_sdk_interfaces.py: builds compiled modules from an SDK #25432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
requested review from
harlanhaskins,
bcardosolopes,
ributzka and
nathawes
jrose-apple
force-pushed
the
swift_build_sdk_interfaces.py
branch
from
042a327 to
3447829
Compare
|
@swift-ci Please smoke test |
harlanhaskins
approved these changes
Jun 13, 2019
jrose-apple
force-pushed
the
swift_build_sdk_interfaces.py
branch
from
3447829 to
1883338
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
ClockKit issue on watchOS. :-( @swift-ci Please smoke test macOS |
...by crawling it and looking for module interfaces. This is the tool Apple is using for the "prebuilt-modules" directory in the toolchain in Xcode.app, which avoids even a first-use cost for importing modules from Apple SDKs as long as the SDKs haven't changed. We've been landing changes to support this model on the compiler side, so the tool to generate the "prebuilt" compiled modules belongs in the compiler repo too. (In theory this could be used with open-source toolchains as well, or for alternate SDKs.)
jrose-apple
force-pushed
the
swift_build_sdk_interfaces.py
branch
from
1883338 to
b2c1035
Compare
|
@swift-ci Please smoke test |
|
*sigh* They're all path separators… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by crawling it and looking for module interfaces. This is the tool Apple is using for the "prebuilt-modules" directory in the toolchain in Xcode.app, which avoids even a first-use cost for importing modules from Apple SDKs as long as the SDKs haven't changed. We've been landing changes to support this model on the compiler side, so the tool to generate the "prebuilt" compiled modules belongs in the compiler repo too. (In theory this could be used with open-source toolchains as well, or for alternate SDKs.)