Implement SE-0039 (Modernizing Playground Literals) #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // FIXME: It feels like a layering violation to mention the protocol | ||
| // kind and description here, but essentially there is a single | ||
| // delcarative way to specify the shape of object literals, their |
There was a problem hiding this comment.
typo "declarative".
I think this approach is reasonable, no need for the FIXME.
|
Aside from the one comment typo, the patch looks great! Question though: what is the migration plan for this? This isn't producing fixits from the old to new syntax, and we want to make sure that playgrounds which use these get moved forward. It is probably worth it to keep the lexer/parser support for the old syntax in just to provide support to move to the new syntax. |
|
I was thinking about the migration plan as well, and that we should have fix-its. I agree keeping the old parser support --- or reworking it for that use case --- makes that possible. |
For example, parse "#Image(imageLiteral:...)" and provide a FixIt to
change it to "#imageLiteral(resourceName:...)". Now we see something like:
test.swift:4:9: error: '#Image' has been renamed to '#imageLiteral
var y = #Image(imageLiteral: "image.jpg")
^~~~~~ ~~~~~~~~~~~~
#imageLiteral resourceName
Handling the old syntax, and providing a FixIt for that, will be handled in a separate
commit.
Needs tests. Will be provided in later commit once full parsing support is done.
... and provide fixits to new syntax. Full tests to come in later commit.
@akyrtzi told me this should be fine.
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
tkremenek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements SE-0039 (Modernizing Playground Literals).