Minor tweaks to Differentiable protocol.
#21521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test tensorflow |
rxwei
reviewed
Dec 22, 2018
| @@ -60,23 +60,25 @@ public extension VectorNumeric { | |||
| public protocol Differentiable { | |||
| /// The tangent vector space of this differentiable manifold. | |||
| associatedtype TangentVector : Differentiable | |||
| where TangentVector.TangentVector == TangentVector | |||
| where TangentVector.TangentVector == TangentVector, | |||
| TangentVector.Scalar : FloatingPoint | |||
There was a problem hiding this comment.
Regarding the build error: I think you need to specify TangentVector's conformance to VectorNumeric here.
dan-zheng
force-pushed
the
differentiable-protocol-tweaks
branch
from
db2574f to
5b29e9b
Compare
|
@swift-ci Please test tensorflow |
|
Ah right, tests should be updated |
|
Updating tests soon! Since the I suppose this is fine and intentional. |
dan-zheng
force-pushed
the
differentiable-protocol-tweaks
branch
2 times, most recently
from
175a0b3 to
71bb3e1
Compare
rxwei
reviewed
Dec 22, 2018
- Conform `TangentVector` and `CotangentVector` to `VectorNumeric where Scalar : FloatingPoint`. - Rename `moved(toward:)` to `moved(along:)`. Also remove extraneous shape-related `VectorNumeric` requirements from `FloatingPoint` types. Those requirements are no longer necessary now that `ShapedVectorNumeric` has been split from `VectorNumeric`.
dan-zheng
force-pushed
the
differentiable-protocol-tweaks
branch
from
71bb3e1 to
3cb371b
Compare
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TangentVectorandCotangentVectortoVectorNumeric where Scalar : FloatingPoint.moved(toward:)tomoved(along:).Also remove extraneous shape-related
VectorNumericrequirements fromFloatingPointtypes. Those requirements are no longer necessary nowthat
ShapedVectorNumerichas been split fromVectorNumeric.